-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core): Updating to AWS SDK for Swift 1.0.0 #3858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Inactive
ruisebas
had a problem deploying
to
IntegrationTest
September 13, 2024 16:26 — with
GitHub Actions
Failure
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:31 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:31 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:31 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:31 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 13, 2024 16:31 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 20:59 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:00 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
September 17, 2024 21:42 — with
GitHub Actions
Inactive
ruisebas
changed the title
feat(Core): Updating to AWS SDK for Swift 0.77.0
feat(Core): Updating to AWS SDK for Swift 1.0.0
Sep 18, 2024
harsh62
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the underlying AWS SDK for Swift dependency to their GA version: 1.0.0.
The vast majority of changes are just types being renamed or moved to different packages, but some business logic had to change here and there. Some of them include:
signingRegion
besides theregion
, so that parameter has been added.CredentialsProviding
has been replaced withAWSCredentialIdentityResolver
for all SDK clients, so our types have been modified accordinglycustomPresignURL
extension toUploadPartInput
had to be re-tweaked to generate a valid URL.Codable
, so we had to manually add it back for some types, mainly Pinpoint and Transcribe, as our operations relied on that.AmplifyStringConvertible
, which had to be fully re-written. It's a non-public debug-only utility anyways.value
would still return a valid key instead of throwing, even though the upload was not completed.Tasks
that wait for expectations, so we don't hang the test if something goes wrong and instead just fail it with missing expectation, allowing for easy retries without having to wait for the 30 minutes timeout.General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.