-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): adding support for email mfa #3862
Merged
Merged
+1,651
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
reviewed
Sep 13, 2024
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Support/Helpers/UserPoolSignInHelper.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3862 +/- ##
==========================================
+ Coverage 69.20% 69.41% +0.20%
==========================================
Files 1087 1087
Lines 49366 49444 +78
==========================================
+ Hits 34163 34320 +157
+ Misses 15203 15124 -79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruisebas
previously approved these changes
Sep 20, 2024
harsh62
had a problem deploying
to
IntegrationTest
September 27, 2024 14:59 — with
GitHub Actions
Failure
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 14:59 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 14:59 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 14:59 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 15:23 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:00 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:00 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:00 — with
GitHub Actions
Inactive
harsh62
had a problem deploying
to
IntegrationTest
October 3, 2024 01:00 — with
GitHub Actions
Failure
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25 — with
GitHub Actions
Inactive
ruisebas
previously approved these changes
Oct 29, 2024
harsh62
force-pushed
the
feat/email-mfa-support-public
branch
from
October 30, 2024 14:36
b5d7595
to
a143244
Compare
harsh62
temporarily deployed
to
IntegrationTest
October 30, 2024 14:37 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 30, 2024 14:37 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 30, 2024 14:37 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 30, 2024 14:37 — with
GitHub Actions
Inactive
ruisebas
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR aims to add support for Email MFA that has been released by Cognito.
https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-settings-advanced-security-email-mfa.html
Depends upon the Swift SDK being upgraded to the latest version with Email MFA models:
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.