Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): adding support for email mfa #3862

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Sep 13, 2024

Description

The PR aims to add support for Email MFA that has been released by Cognito.
https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-settings-advanced-security-email-mfa.html

Depends upon the Swift SDK being upgraded to the latest version with Email MFA models:

Integration Tests | Auth

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 76.25899% with 33 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (2a3de4b) to head (a143244).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...in/Actions/SignIn/InitializeResolveChallenge.swift 74.46% 12 Missing ⚠️
...es/AWSCognitoAuthPlugin/Models/MFAPreference.swift 0.00% 12 Missing ⚠️
...solvers/SignIn/SignInChallengeState+Resolver.swift 81.25% 3 Missing ⚠️
...ignIn/SoftwareTokenSetup/InitializeTOTPSetup.swift 0.00% 2 Missing ⚠️
.../Actions/SignIn/SoftwareTokenSetup/SetUpTOTP.swift 0.00% 2 Missing ⚠️
...hPlugin/Actions/SignIn/VerifySignInChallenge.swift 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
+ Coverage   69.20%   69.41%   +0.20%     
==========================================
  Files        1087     1087              
  Lines       49366    49444      +78     
==========================================
+ Hits        34163    34320     +157     
+ Misses      15203    15124      -79     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (ø)
AWSPluginsCore 70.36% <ø> (ø)
Amplify 48.18% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 80.17% <76.25%> (+0.06%) ⬆️
DataStore_plugin_unit_test 84.25% <ø> (+0.95%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.11% <ø> (ø)
Predictions_plugin_unit_test 35.49% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.88% <ø> (ø)
unit_tests 69.41% <76.25%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruisebas
ruisebas previously approved these changes Sep 20, 2024
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:00 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:00 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:00 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:49 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:49 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:49 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 01:49 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 14:42 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 14:42 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest October 3, 2024 14:42 — with GitHub Actions Inactive
ruisebas
ruisebas previously approved these changes Oct 29, 2024
@harsh62 harsh62 merged commit 71e4df0 into main Oct 30, 2024
97 checks passed
@harsh62 harsh62 deleted the feat/email-mfa-support-public branch October 30, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants