Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle decoding errors #3765

Closed

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Handle runtime decoding errors during websocket connection

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner July 1, 2024 21:18
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.28%. Comparing base (1a5386d) to head (2dedf5f).

Files Patch % Lines
...sPlugin/Liveness/Service/FaceLivenessSession.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/no-light-support    #3765   +/-   ##
======================================================
  Coverage                  68.28%   68.28%           
======================================================
  Files                       1082     1082           
  Lines                      37686    37687    +1     
======================================================
+ Hits                       25732    25734    +2     
+ Misses                     11954    11953    -1     
Flag Coverage Δ
API_plugin_unit_test 68.83% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.65% <ø> (+0.06%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.40% <ø> (-0.01%) ⬇️
DataStore_plugin_unit_test 81.27% <ø> (-0.02%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 36.55% <0.00%> (-0.02%) ⬇️
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.28% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisisabhash thisisabhash deleted the fix/handle-decoding-error branch July 2, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant