New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: handle decoding errors #152

Closed

thisisabhash wants to merge 1 commit into feat/no-light-support from fix/handle-decoding-error

Member

thisisabhash commented Jul 1, 2024 •

edited

Loading

Issue #, if available:
None

Description of changes:

Handle decoding errors e.g. unknown challenge type received in ChallengeEvent
Resolve below compiler warning:
Accessing StateObject's object without being installed on a View. This will create a new instance each time.

Check points: (check or cross out if not relevant)

Added new tests to cover change, if needed
Build succeeds with all target using Swift Package Manager
All unit tests pass
Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
Documentation update for the change if required
PR title conforms to conventional commit style
If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          chore: handle decoding errors

8f3b75a

thisisabhash requested review from a team as code owners

July 1, 2024 21:29

Member Author

thisisabhash commented Jul 1, 2024

Build failure due to this change: aws-amplify/amplify-swift#3765 not yet merged.

thisisabhash closed this

thisisabhash deleted the fix/handle-decoding-error branch

July 2, 2024 17:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet