fix(analytics): update error handling #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
phantumcode
reviewed
Oct 2, 2023
|
|
||
| class AnalyticsErrorHelper { | ||
| enum AnalyticsErrorHelper { |
There was a problem hiding this comment.
curious why this was changed from class to enum?
There was a problem hiding this comment.
I think I must've instinctively made that change without realizing it.
As a simple namespace, it should be an enum. That said, I don't mind reverting as it doesn't really belong in this PR.
phantumcode
approved these changes
Oct 2, 2023
ruisebas
reviewed
Oct 2, 2023
| request.headers = headers | ||
| for header in headers.headers { | ||
| for value in header.value { | ||
| request.withHeader(name: header.name, value: value) |
There was a problem hiding this comment.
Looking at how this is implemented, it looks like we'll be adding all the original headers to the new additionalHeaders list, which will then be combined with the original headers resulting in unnecessary duplication.
I believe we can just do this instead:
request.withHeader(
name: userAgentHeader,
value: "\(currentUserAgent)\(userAgentSuffix)"
)But now I wonder, would we be sending two values for the User-Agent header then? 🤔. Would that still work?
atierian
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift SDK Update 0.26.0
Makes necessary changes to get AWSPluginsCore to compile.
Debt Introduced
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.