-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): update swift sdk dependency version to 0.26.0 #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2023
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:17 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 3, 2023 13:18 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 9, 2023 18:58 — with
GitHub Actions
Inactive
phantumcode
reviewed
Oct 9, 2023
...uthPluginUnitTests/TaskTests/ClientBehaviorTests/AuthenticationProviderDeleteUserTests.swift
Outdated
Show resolved
Hide resolved
phantumcode
reviewed
Oct 9, 2023
...uthPluginUnitTests/TaskTests/ClientBehaviorTests/AuthenticationProviderDeleteUserTests.swift
Outdated
Show resolved
Hide resolved
phantumcode
approved these changes
Oct 10, 2023
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the staging branch for the many updates that need to occur to update our dependency on the AWS SDK for Swift to 0.26.0.
Description of Changes
UserAgentSettingClientEngine
and uses it for all SDK Client Configurations in order to set thelib
component of theUser-Agent
header.PRs
🚧 Pending Work
👀 In Review
✅ Merged into
swift-sdk-0260
Required Changes
🟦 No changes required
🟢 Non-Functional Changes (e.g. config / dependency version / type renaming)
🔶 Functional Changes
Open Items
FrameworkMetadata
type added in fix: resolve compiler errors in AWSPluginsCore after sdk update #3247HttpClientEngine
s everywhere needed to inject user-agent header. Resolves debt introduced in fix: update sdk error handling in AWSCognitoAuthPlugin #3251Documentation Updates
Escape Hatch Documentation Audit
✅ Authentication > Escape hatch
✅ Analytics > Escape hatch
✅ Geo > Escape hatch
✅ Predictions > Escape hatch
✅ Storage > Escape hatch
✅ Logging > Escape hatch
General Checklist
Documentation update for the change if requiredGiven When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.