Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): not sign the empty body of the get remote config request #3947

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix(logging): not sign the empty body of the get remote config request #3947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/remote_constraint_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ base class BaseRemoteLoggingConstraintProvider
FileStorage? fileStorage,
}) : _fileStorage = fileStorage,
_config = config,
_awsHttpClient = AWSHttpClient() {
_awsHttpClient = AWSHttpClient()
..supportedProtocols = SupportedProtocols.http1 {
_init();
}

Expand Down Expand Up @@ -120,9 +121,10 @@ base class BaseRemoteLoggingConstraintProvider
jsonEncode(fetchedConstraint.toJson()),
);
}
} on Exception catch (exception) {
} on Object catch (exception, st) {
logger.error(
'Failed to fetch logging constraint from ${_config.endpoint}: $exception',
'Failed to fetch logging constraint from ${_config.endpoint}. exception: $exception, stack: $st',
st,
);
}
}
Expand Down Expand Up @@ -194,6 +196,7 @@ final class DefaultRemoteLoggingConstraintProvider
final signedRequest = await _signer.sign(
baseRequest,
credentialScope: scope,
serviceConfiguration: const ServiceConfiguration(signBody: false),
);

return signedRequest;
Expand Down
Loading