Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): not sign the empty body of the get remote config request #3947

Merged

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Oct 13, 2023

Issue #, if available:

  • add http1 to supported protocols
  • fix the request signer to not sign the empty body. it causes the remote config request to fail on the web

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner October 13, 2023 20:15
@NikaHsn NikaHsn merged commit 164c08d into aws-amplify:feat/logging/cloudwatch Oct 13, 2023
119 of 152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants