Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nebula_node_container.launch.py): autoware_glog_component #112

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Dec 6, 2024

Description

The same as autowarefoundation/autoware_launch#1260.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <[email protected]>
Copy link

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Reason:

  • This PR looks tested with autoware-nighty.repos. I investigated the possible side effects by this PR. Considering we use autoware.repos for stable one and autoware-nighty.repos for the latest one as this installation tutorial, this PR can fix the issue in using the latest one. So I agree with merging this PR 👍 . Thank you so much!

@SakodaShintaro SakodaShintaro marked this pull request as ready for review December 6, 2024 10:24
@SakodaShintaro SakodaShintaro merged commit 3e652bf into autowarefoundation:main Dec 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants