Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_msgs): add new optional messages package with published time debug message #83

Closed

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Feb 16, 2024

Description

Closes: autowarefoundation/autoware.universe#6255

We want to add a new message which will report the header time and published time of a message inside the pipelines.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r
Copy link
Member

mitsudome-r commented Feb 19, 2024

Let's create a new package called autoware_optional_msgs since this won't be used as a main interface.

@brkay54 brkay54 force-pushed the feat/add-publishedtime-msg branch from 598b81a to ac49ce1 Compare February 25, 2024 16:49
@brkay54 brkay54 changed the title feat(autoware_common_msgs): add published time debug message feat(autoware_msgs): add new optional messages package with published time debug message Feb 26, 2024
@yukkysaito
Copy link
Collaborator

yukkysaito commented Feb 26, 2024

@brkay54 @mitsudome-r
This is not a formal interface and should not be included in autoware_msgs. 🙏

@mitsudome-r
Copy link
Member

I have created https://github.com/autowarefoundation/autoware_internal_msgs so let's put this message there.

@brkay54 brkay54 closed this Feb 26, 2024
@brkay54
Copy link
Member Author

brkay54 commented Feb 26, 2024

autowarefoundation/autoware_internal_msgs#1 Created another PR.

@brkay54 brkay54 deleted the feat/add-publishedtime-msg branch February 26, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to detect publishing times of the messages in the pipelines
3 participants