Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_stop_planner): change stop distance after goal #758

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 26, 2023

Description

goal planner's longitudinal_margin: 3.0 is exactly same to terminal_safe_distance_margin and max_longitudinal_margin_behind_goal.
This may prevent arrving the goal, so the value is slightly reduced.

Tests performed

with obstacle stop planner

before

image

after

image

pull_over_scenario-2023-12-26_11.56.42.mp4

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @kosuke55 wants, I have no concerns.

@kosuke55 kosuke55 changed the title feat(obstacle_stop/cruise): change stop distance after goal feat(obstacle_stop): change stop distance after goal Dec 26, 2023
…/motion_planning/obstacle_cruise_planner/obstacle_cruise_planner.param.yaml
@kosuke55 kosuke55 changed the title feat(obstacle_stop): change stop distance after goal feat(obstacle_stop_planner): change stop distance after goal Dec 26, 2023
@kosuke55 kosuke55 merged commit 8057562 into main Dec 26, 2023
11 of 12 checks passed
@kosuke55 kosuke55 deleted the feat/change_stop_distance_after_goal branch December 26, 2023 10:55
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants