Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light): stop if the traffic light signal timed out #727

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Dec 8, 2023

Description

See autowarefoundation/autoware.universe#5819

Related links

Tests performed

See autowarefoundation/autoware.universe#5819

Notes for reviewers

Interface changes

stop_time_hysteresis is added.

Effects on system behavior

See autowarefoundation/autoware.universe#5819

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 rej55 merged commit 192a250 into autowarefoundation:main Dec 11, 2023
9 of 10 checks passed
@rej55 rej55 deleted the fix/traffic_light_time_out_behavior branch December 11, 2023 11:11
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
…foundation#727)

* feat(system_error_monitor): enable lane_depature monitoring

* Update autoware_launch/config/system/system_error_monitor/system_error_monitor.param.yaml
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
* feat: tune condition of between cruise and stop (autowarefoundation#565)

Tune condition of between cruise and stop

* fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#727) (autowarefoundation#571)

Signed-off-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>

* feat(component_state_monitor): monitor traffic light recognition outp… (autowarefoundation#572)

feat(component_state_monitor): monitor traffic light recognition output (autowarefoundation#720)

Signed-off-by: Tomohito Ando <[email protected]>

* update ground segmentation

Signed-off-by: yoshiri <[email protected]>

* update comparemap parameter

Signed-off-by: yoshiri <[email protected]>

* update clustering parameters

Signed-off-by: yoshiri <[email protected]>

* fix tracking iou threshold parameters

Signed-off-by: yoshiri <[email protected]>

* feat: set smaller  threshold for euclidean clustering

Signed-off-by: yoshiri <[email protected]>

* chore: fit parameter for v3.0.0

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 18, 2024
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* feat: tune condition of between cruise and stop (#565)

Tune condition of between cruise and stop

* fix(traffic_light): stop if the traffic light signal timed out (#727) (#571)

Signed-off-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>

* feat(component_state_monitor): monitor traffic light recognition outp… (#572)

feat(component_state_monitor): monitor traffic light recognition output (#720)

Signed-off-by: Tomohito Ando <[email protected]>

* update ground segmentation

Signed-off-by: yoshiri <[email protected]>

* update comparemap parameter

Signed-off-by: yoshiri <[email protected]>

* update clustering parameters

Signed-off-by: yoshiri <[email protected]>

* fix tracking iou threshold parameters

Signed-off-by: yoshiri <[email protected]>

* feat: set smaller  threshold for euclidean clustering

Signed-off-by: yoshiri <[email protected]>

* chore: fit parameter for v3.0.0

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
…her-v310

feat: split autoware launch for main and sub ecu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants