Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_launch): add localization_input_pointcloud argument to autoware.launch #712

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Nov 29, 2023

Description

I have modified Autoware to allow specifying the topic name for the point cloud used in localization module as an command-line argument.
(A solution for addressing scenarios involving the external modification of point clouds used in localization, followed by the execution of identical scenario evaluations to compare results. TIER IV INTERNAL LINK )

Tests performed

  1. I have checked that planning_simulator launches successfully.
    $ros2 launch autoware_launch planning_simulator.launch.xml vehicle_id:=default vehicle_model:=lexus sensor_model:=aip_xx1 map_path:=[MAP_PATH]

  2. I have checked that the parameters of localization_input_pointcloud are successfully reflected in the localization module."
    $ros2 launch autoware_launch autoware.launch.xml vehicle_id:=default vehicle_model:=lexus sensor_model:=aip_xx1 map_path:=[MAP_PATH] localization_input_pointcloud:=/x
    $ros2 node info /localization/util/crop_box_filter_measurement_range

  Subscribers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /x: sensor_msgs/msg/PointCloud2
...

Effects on system behavior

Not applicable ( There is no effect on the default behavior ).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tkimura4 tkimura4 requested a review from 0x126 November 29, 2023 08:11
Signed-off-by: tomoya.kimura <[email protected]>
@tkimura4 tkimura4 marked this pull request as draft November 29, 2023 08:18
@tkimura4 tkimura4 marked this pull request as ready for review November 30, 2023 04:17
@tkimura4 tkimura4 closed this Dec 20, 2023
sykwer pushed a commit to sykwer/autoware_launch that referenced this pull request Jan 3, 2024
…ning_launch instead (autowarefoundation#712)

* refactor(autoware_launch): remove planning_launch, and use tier4_planning_launch instead

Signed-off-by: Takayuki Murooka <[email protected]>

* add tier4_planning_component.launch.xml

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
@tkimura4 tkimura4 deleted the chore/parameterize_loc_pcd_in_autoware_launch branch December 23, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant