Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): modified ndt_scan_matcher.param.yaml to match with the one in universe #596

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Sep 27, 2023

Description

Fixed ndt_scan_matcher.param.yaml to match with the one in universe.
Related: autowarefoundation/autoware.universe#5155

Tests performed

autoware_launch successfully built, and rosbag replay simulation in the tutorial has been tested in my environment.

Effects on system behavior

This shouldn't affect the system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 changed the title Modified ndt_scan_matcher.param.yaml to match with the one in universe refactor(ndt_scan_matcher): modified ndt_scan_matcher.param.yaml to match with the one in universe Sep 27, 2023
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review September 28, 2023 08:45
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaikiYamada4 TaikiYamada4 enabled auto-merge (squash) September 28, 2023 08:47
@TaikiYamada4 TaikiYamada4 merged commit 206d439 into autowarefoundation:main Sep 28, 2023
8 of 9 checks passed
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…ng launch file (autowarefoundation#596)

Signed-off-by: Maxime CLEMENT <[email protected]>

Signed-off-by: Maxime CLEMENT <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…ng launch file (autowarefoundation#596) (autowarefoundation#597)

Signed-off-by: Maxime CLEMENT <[email protected]>

Signed-off-by: Maxime CLEMENT <[email protected]>

Signed-off-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants