-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ndt_scan_matcher): modified ndt_scan_matcher.param.yaml to match with the one in universe #596
Merged
TaikiYamada4
merged 2 commits into
autowarefoundation:main
from
TaikiYamada4:refactor/ndt_scan_matcher_parameters
Sep 28, 2023
Merged
refactor(ndt_scan_matcher): modified ndt_scan_matcher.param.yaml to match with the one in universe #596
TaikiYamada4
merged 2 commits into
autowarefoundation:main
from
TaikiYamada4:refactor/ndt_scan_matcher_parameters
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
changed the title
Modified ndt_scan_matcher.param.yaml to match with the one in universe
refactor(ndt_scan_matcher): modified ndt_scan_matcher.param.yaml to match with the one in universe
Sep 27, 2023
4 tasks
KYabuuchi
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 29, 2023
This was referenced Oct 11, 2023
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware_launch.awf
that referenced
this pull request
Oct 20, 2023
…ng launch file (autowarefoundation#596) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]>
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware_launch.awf
that referenced
this pull request
Oct 20, 2023
…ng launch file (autowarefoundation#596) (autowarefoundation#597) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Maxime CLEMENT <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
Signed-off-by: 1222-takeshi <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
…ation#596) Signed-off-by: Tomohito Ando <[email protected]>
yuki-takagi-66
referenced
this pull request
in tier4/autoware_launch
Jul 8, 2024
Signed-off-by: Tomohito Ando <[email protected]>
Kazunori-Nakajima
pushed a commit
to Kazunori-Nakajima/autoware_launch
that referenced
this pull request
Oct 17, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed ndt_scan_matcher.param.yaml to match with the one in universe.
Related: autowarefoundation/autoware.universe#5155
Tests performed
autoware_launch successfully built, and rosbag replay simulation in the tutorial has been tested in my environment.
Effects on system behavior
This shouldn't affect the system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.