Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent start planner execution in the middle of the road #579

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Sep 21, 2023

Description

🤖 Generated by Copilot at 1e0f5c6

Add a new parameter th_distance_to_middle_of_the_road to the start planner module, which controls whether the module should be executed or not based on the lateral distance to the center of the current lane. Update the configuration file, the header file, and the source files accordingly.

Related links

Universe changes link

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@danielsanchezaran danielsanchezaran marked this pull request as ready for review September 21, 2023 05:08
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielsanchezaran danielsanchezaran force-pushed the RT1-3754-prevent-start-planner-execution-in-the-middle-of-the-road branch from ab76c25 to 6fa12e5 Compare September 21, 2023 05:21
@danielsanchezaran danielsanchezaran changed the title Rt1 3754 prevent start planner execution in the middle of the road feat: prevent start planner execution in the middle of the road Sep 21, 2023
@danielsanchezaran danielsanchezaran merged commit b5e6116 into autowarefoundation:main Sep 21, 2023
8 of 10 checks passed
@danielsanchezaran danielsanchezaran deleted the RT1-3754-prevent-start-planner-execution-in-the-middle-of-the-road branch September 21, 2023 05:36
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…warefoundation#579) (autowarefoundation#642)

* start planner:new param: dist th to middle of road



* refactor param order



---------

Signed-off-by: Daniel Sanchez <[email protected]>
Co-authored-by: danielsanchezaran <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
Ericpotato pushed a commit that referenced this pull request Nov 6, 2024
chore: sync tier4/autoware_launch:awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants