feat(perception): add data_path argument to launch file #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Panferov <[email protected]>
xmfcx
approved these changes
Sep 20, 2023
|
@lexavtanke I've enabled automerge for this PR, once CI passes it'll be merged. |
38 tasks
This was referenced Sep 21, 2023
4 tasks
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware_launch.awf
that referenced
this pull request
Oct 20, 2023
…autowarefoundation#577) Signed-off-by: Makoto Kurihara <[email protected]> Signed-off-by: Makoto Kurihara <[email protected]>
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
Nov 18, 2023
Signed-off-by: tomoya.kimura <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
Signed-off-by: tomoya.kimura <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
autowarefoundation#577) feat(planning): add enable_all_modules_auto_mode argument to launch files for planning modules (autowarefoundation#798) * Add auto mode setting for all modules Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]>
yuki-takagi-66
referenced
this pull request
in tier4/autoware_launch
Jul 8, 2024
#577) feat(planning): add enable_all_modules_auto_mode argument to launch files for planning modules (autowarefoundation#798) * Add auto mode setting for all modules Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Belongs to Standardize a strategy for packages with downloaded artifacts
As artifact downloading in ansible was merged to Autoware.universe. It is possible to use artifacts downloaded there.
This PR introduces new launch argument data_path in the form:
<arg name="data_path" default="$(env HOME)/autoware_data" description="packages data and artifacts directory path"/>It should be downstreamed to all packages with downloaded artifacts, mostly perception.
See autowarefoundation/autoware.universe#3137
Tests performed
Logging_simulator and planning_simulator launch fine with this parameter.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.