Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories #1253

Merged
merged 5 commits into from
Nov 29, 2024
Merged

refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories #1253

merged 5 commits into from
Nov 29, 2024

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Nov 26, 2024 •
edited
Loading

Description

Currently, by the historical reason, diagnostic graph settings are located in the following three directories

  1. diagnostc_graph_aggregator: link to system_diagnostic_monitor
  2. system_diagnostic_monitor: path settings to be checked
  3. dummy_diag_publisher: path settings to be ignore

This PR merge these directories to one directory.
This PR does not contains any behavior change.

Related links

part of #1221

Tests performed

passed tier4 scenario tests

diagnostic graph status in psim environment is as follow
image

Driving in awsim environment is tested.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yuki-takagi-66
change diag dir
007662a 
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66
change file dir
4275b53 
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66
delete link file
0120249 
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66
change link form
8b70002 
Signed-off-by: yuki-takagi-66 <[email protected]>
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 26, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title Takagi/diag/merge directories refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list directories Nov 26, 2024
@yuki-takagi-66
set awsim
56012ea 
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review November 27, 2024 09:14
@yuki-takagi-66 yuki-takagi-66 changed the title refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list directories refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories Nov 27, 2024
isamu-takagi
isamu-takagi approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-takagi-66 yuki-takagi-66 merged commit 4826faf into autowarefoundation:main Nov 29, 2024
19 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/diag/merge-directories branch November 29, 2024 04:07
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Nov 29, 2024
@yuki-takagi-66
refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_…
cc3b7b9 
…graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Nov 29, 2024
Merged
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Nov 29, 2024
@tier4-autoware-public-bot @yuki-takagi-66
chore: sync awf-latest (#696)
1a43361 
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: yuki-takagi-66 <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Nov 29, 2024
Merged
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Dec 3, 2024
@tier4-autoware-public-bot @yuki-takagi-66
@sebekx @xtk8532704
chore: sync awf-latest (#697)
63bfe66 
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: Sebastian Zęderowski <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Kem (TiankuiXian) <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 3, 2024
Merged
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Dec 5, 2024
@tier4-autoware-public-bot @yuki-takagi-66
@sebekx @xtk8532704 @esteve @mkquda
chore: sync awf-latest (#701)
491c776 
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <[email protected]>

* refactor(glog_component): prefix package and namespace with autoware (autowarefoundation#1245)

Signed-off-by: Esteve Fernandez <[email protected]>

* refactor(global_parameter_loader): prefix package and namespace with autoware (autowarefoundation#1246)

Signed-off-by: Esteve Fernandez <[email protected]>

* feat(lane_change): add new lane change parameter (autowarefoundation#1224)

* add minimum prepare duration parameter

Signed-off-by: mohammad alqudah <[email protected]>

* increase min_prepare_duration to 1.0 s

Signed-off-by: mohammad alqudah <[email protected]>

* increase min prepare duration value, add new parameter

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: Sebastian Zęderowski <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Kem (TiankuiXian) <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: mkquda <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

Assignees

@isamu-takagi isamu-takagi

Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuki-takagi-66 @mitsudome-r @isamu-takagi