revert(obstacle_cruisse): revert "fix(obstacle_cruise_planner): guarantee the stop margin (#1076)" #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warefoundation#1076)" This reverts commit 2602ebd.
yuki-takagi-66
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
takayuki5168
approved these changes
Oct 10, 2024
yuki-takagi-66
merged commit a68a267
into
autowarefoundation:main
12 of 13 checks passed
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Oct 10, 2024
…ntee the stop margin (autowarefoundation#1076)" (autowarefoundation#1185) Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Oct 10, 2024
* feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out (autowarefoundation#1142) Signed-off-by: Berkay Karaman <[email protected]> * revert(obstacle_cruise): reduce using predicted paths to maintain conventional behavior (#621) Signed-off-by: Yuki Takagi <[email protected]> * revert(obstacle_cruisse): revert "fix(obstacle_cruise_planner): guarantee the stop margin (autowarefoundation#1076)" (autowarefoundation#1185) Signed-off-by: Yuki Takagi <[email protected]> --------- Signed-off-by: Berkay Karaman <[email protected]> Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Berkay Karaman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we can achieve a stop with a margin for interrupts, thanks to the stop with predicted_path by @brkay54 autowarefoundation/autoware.universe#8072. Since the need for sudden stops has been reduced, we will revert this parameter.
This reverts the PR #1076
Tests performed
scenario tests
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.