Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_internal_msgs): add PublishedTime debug info message #1

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Feb 26, 2024

Description

Part of:

We want to add a new message that will report the header time and published time of a message inside the pipelines.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54
Copy link
Member Author

brkay54 commented Feb 26, 2024

@xmfcx, @mitsudome-r -san Could you review also who wants to maintain the package?

@yukkysaito
Copy link

I would like to have @yukkysaito @xmfcx @mitsudome-r as the maintainers of message interface.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2024

@brkay54 could you also open up a PR to update the autoware/autoware.repos file too? (to include autoware_internal_msgs within autoware/core folder)?

@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2024

And I will add a simple CI for this repo before merging this.

Copy link

codecov bot commented Feb 26, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@xmfcx xmfcx force-pushed the feat/add-published-time branch 2 times, most recently from 62ecb40 to f2f5342 Compare February 26, 2024 17:41
msg/PublishedTime.msg Outdated Show resolved Hide resolved
msg/PublishedTime.msg Outdated Show resolved Hide resolved
@brkay54 brkay54 force-pushed the feat/add-published-time branch from f2f5342 to f75ca99 Compare February 27, 2024 15:05
@xmfcx xmfcx force-pushed the feat/add-published-time branch from 40fa6e2 to e803c4e Compare February 27, 2024 15:29
package.xml Show resolved Hide resolved
msg/PublishedTime.msg Outdated Show resolved Hide resolved
msg/PublishedTime.msg Outdated Show resolved Hide resolved
@brkay54 brkay54 force-pushed the feat/add-published-time branch from e803c4e to ecaf900 Compare February 29, 2024 08:33
@brkay54 brkay54 requested a review from xmfcx February 29, 2024 08:38
@brkay54 brkay54 force-pushed the feat/add-published-time branch from ecaf900 to 45cb089 Compare February 29, 2024 08:41
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants