Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(individaul_params): add concatenate node parameters #54

Conversation

vividf
Copy link

@vividf vividf commented Dec 2, 2024

Description

PR autowarefoundation/autoware.universe#8300 removed the default parameters from the node, thus this PR is needed for sample_sensor, awsim, and awsim_labs to load concatenate node parameters

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf vividf marked this pull request as draft December 3, 2024 02:44
@SakodaShintaro
Copy link

@vividf
I believe some parameters (for example, input_topics, publish_synchronized_pointcloud, and so on) are not related to individuals but are instead related to the sensor kit.
Is it difficult to separate the parameters related to individuals from those related to the sensor kit?

@vividf
Copy link
Author

vividf commented Dec 9, 2024

@SakodaShintaro
This PR was initially created because we discovered that one of the vehicles had a different timestamp offset between its LiDARs. As a result, we decided to introduce a separate parameter for each vehicle ID. However, it has since been confirmed that the offset issue was due to the vehicle's sensors not being synchronized.

Therefore, this PR is no longer necessary, and all relevant parameters have been consolidated into the sensor_kit_launch configuration.

@vividf vividf closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants