Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sample_sensor_kit_launch): concatenate node load from parameter file #108

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Oct 29, 2024

Description

This PR remove the default parameter from the node.
Thus, the launcher also needs to load from the parameter file.

Related links

Tests performed

# Terminal 1
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-rosbag vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit

# Terminal 2
ros2 bag play sample-rosbag_0.db3

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mojomex
Copy link
Contributor

mojomex commented Oct 31, 2024

I'm not sure about duplicating parameter files. If there is an update to the concat node in the future, this duplicated config needs to be updated in a PR to sample_sensor_kit_launch as well.
Are there any reasons against using the param file in concat itself by using concat's package share directory?

@vividf
Copy link
Contributor Author

vividf commented Oct 31, 2024

@mojomex I agree that loading additional parameter files from sensor_kit makes the procedure more complicated but for the aip_launcher this is needed since each project has its own parameters 😿

If aip_launcher needs to be implemented in this way, sample_sensor_kit should follow the same approach to maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants