Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): change base_image to ros:humble-ros-core-jammy #4808

Closed
wants to merge 5 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jun 3, 2024

Description

This PR changes base_image of the Dockerfile from ros:humble-ros-base-jammy to ros:humble-ros-core-jammy to decrease the image size.

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/9359817720

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@youtalk youtalk changed the title feat(docker): change base_image to ros:humb-ros-core-jammy feat(docker): change base_image to ros:humble-ros-core-jammy Jun 4, 2024
@youtalk youtalk marked this pull request as ready for review June 4, 2024 03:27
@youtalk youtalk self-assigned this Jun 4, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jun 4, 2024

@youtalk san, could you also test the autoware.universe build and test ci with an image generated with this action? If it passes, we can merge.

@youtalk
Copy link
Member Author

youtalk commented Jun 5, 2024

Due to the autoware.universe CI faiure, I first closed this PR.
https://github.com/autowarefoundation/autoware.universe/actions/runs/9376436454/job/25816364727

@youtalk youtalk closed this Jun 5, 2024
@youtalk youtalk deleted the humble-core branch June 5, 2024 01:29
@youtalk youtalk removed their assignment Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants