chore: hold check of plotjuggler-ros package and display warning if held #4805

Naophis · 2024-06-03T06:05:28Z

Description

This PR implements a similar fix to the one applied in #4781
The changes address the handling of the plotjuggler-ros installation process, specifically when packages are already pinned.

Tests performed

premise

before

Errored in Install plotjuggler

after(held packages)

install escaped.

after (not held packages)

update success.

after(initial setup)

install success.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Naophis <[email protected]>

…ackage Signed-off-by: Naophis <[email protected]>

* chore(docker): separate `rosdep install` and `colcon build` RUN commands (autowarefoundation#4719) * refactor(ci): reuse `load-env.yaml` to load env (autowarefoundation#4734) * reuse load-env.yaml to load env * update base_image Signed-off-by: Yutaka Kondo <[email protected]> * fix base_image Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * refactor(docker): introduce `src-imported` stage (autowarefoundation#4712) * introduce src-imported stage Signed-off-by: Yutaka Kondo <[email protected]> * empty Signed-off-by: Yutaka Kondo <[email protected]> * generate install package lists * append || true Signed-off-by: Yutaka Kondo <[email protected]> * cat packages Signed-off-by: Yutaka Kondo <[email protected]> * chore(docker): separate `rosdep install` and `colcon build` RUN commands (autowarefoundation#4719) * wip Signed-off-by: Yutaka Kondo <[email protected]> * wip Signed-off-by: Yutaka Kondo <[email protected]> * Update Dockerfile * Update Dockerfile * install pacmod * rename * Revert "install pacmod" This reverts commit ebff10f. * install pacmod3 * register pamod3 repos * ignore hadolint * revert * run set-dev-env.sh * pip install * copy * rosdep update --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker): install minimum packages in `base` stage (autowarefoundation#4751) * install ssh only and copy only once Signed-off-by: Yutaka Kondo <[email protected]> * install gosu Signed-off-by: Yutaka Kondo <[email protected]> * fix dir Signed-off-by: Yutaka Kondo <[email protected]> * revert ansible Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * chore: add discussion templates for general category (autowarefoundation#4764) Signed-off-by: Ryohsuke Mitsudome <[email protected]> * feat(ci,docker): change `vcs import` to `COPY src` (autowarefoundation#4738) * introduce src-imported stage Signed-off-by: Yutaka Kondo <[email protected]> * empty Signed-off-by: Yutaka Kondo <[email protected]> * generate install package lists * append || true Signed-off-by: Yutaka Kondo <[email protected]> * cat packages Signed-off-by: Yutaka Kondo <[email protected]> * chore(docker): separate `rosdep install` and `colcon build` RUN commands (autowarefoundation#4719) * wip Signed-off-by: Yutaka Kondo <[email protected]> * wip Signed-off-by: Yutaka Kondo <[email protected]> * Update Dockerfile * Update Dockerfile * install pacmod * rename * Revert "install pacmod" This reverts commit ebff10f. * install pacmod3 * register pamod3 repos * ignore hadolint * revert * run set-dev-env.sh * pip install * copy * rosdep update * vcs import outside dockerfile Signed-off-by: Yutaka Kondo <[email protected]> * refine order and remove /autoware/src at last * fix hadolint * remove tar files Signed-off-by: Yutaka Kondo <[email protected]> * shell: bash Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker,ansible): download artifacts at runtime (autowarefoundation#4771) * feat(ci): enable Docker build cache to 5 times faster container build (autowarefoundation#4730) * introduce src-imported stage Signed-off-by: Yutaka Kondo <[email protected]> * empty Signed-off-by: Yutaka Kondo <[email protected]> * generate install package lists * append || true Signed-off-by: Yutaka Kondo <[email protected]> * cat packages Signed-off-by: Yutaka Kondo <[email protected]> * chore(docker): separate `rosdep install` and `colcon build` RUN commands (autowarefoundation#4719) * wip Signed-off-by: Yutaka Kondo <[email protected]> * wip Signed-off-by: Yutaka Kondo <[email protected]> * Update Dockerfile * Update Dockerfile * install pacmod * rename * Revert "install pacmod" This reverts commit ebff10f. * install pacmod3 * register pamod3 repos * ignore hadolint * revert * run set-dev-env.sh * pip install * copy * rosdep update * vcs import outside dockerfile Signed-off-by: Yutaka Kondo <[email protected]> * enable docker build cache Signed-off-by: Yutaka Kondo <[email protected]> * empty Signed-off-by: Yutaka Kondo <[email protected]> * add no-cuda/cuda suffix Signed-off-by: Yutaka Kondo <[email protected]> * remove --download-artifacts Signed-off-by: Yutaka Kondo <[email protected]> * remove --download-artifacts Signed-off-by: Yutaka Kondo <[email protected]> * add --data-path option Signed-off-by: Yutaka Kondo <[email protected]> * wip Signed-off-by: Yutaka Kondo <[email protected]> * run download_artifacts Signed-off-by: Yutaka Kondo <[email protected]> * remove todo Signed-off-by: Yutaka Kondo <[email protected]> * revert run Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker): cache `ccache` to the Docker build cache (autowarefoundation#4772) * fix: add download url of yolox with semantic segmentation header (autowarefoundation#4012) Signed-off-by: badai-nguyen <[email protected]> * chore: add error handling for held packages during rmw installation (autowarefoundation#4781) * chore: add error handling for held packages during apt installation Signed-off-by: Naophis <[email protected]> * feat: Add check for held ROS packages during installation Signed-off-by: Naophis <[email protected]> --------- Signed-off-by: Naophis <[email protected]> * refactor(docker,ci): rename `autoware-openadk` to `autoware` and `adkit` to `openadkit` (autowarefoundation#4785) * rename adkit to openadkit Signed-off-by: Yutaka Kondo <[email protected]> * rename autoware-openadkit to autoware Signed-off-by: Yutaka Kondo <[email protected]> * fix hcl path Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(ci): disable `Upload Artifacts` on `docker-build-and-push` action (autowarefoundation#4789) * remove upload artifact Signed-off-by: Yutaka Kondo <[email protected]> * remove build and push Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker): cache apt archives to the Docker build cache (autowarefoundation#4778) * mount apt cache Signed-off-by: Yutaka Kondo <[email protected]> * reorder Signed-off-by: Yutaka Kondo <[email protected]> * remove upload artifact Signed-off-by: Yutaka Kondo <[email protected]> * remove build and push Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * chore: update code owners (autowarefoundation#4797) Signed-off-by: M. Fatih Cırıt <[email protected]> * ci(pre-commit-ansible): autoupdate (autowarefoundation#4676) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * ci: pre-commit autoupdate (autowarefoundation#4670) [pre-commit.ci] pre-commit autoupdate updates: - [github.com/igorshubovych/markdownlint-cli: v0.39.0 → v0.41.0](igorshubovych/markdownlint-cli@v0.39.0...v0.41.0) - [github.com/AleksaC/hadolint-py: v2.12.1-beta → v2.12.1b3](AleksaC/hadolint-py@v2.12.1-beta...v2.12.1b3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (autowarefoundation#4662) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * ci(pre-commit-optional): autoupdate (autowarefoundation#4766) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * fix(ci): run `vsc import` on `build-main` workflows (autowarefoundation#4799) Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker): cache `ccache` to the Docker build cache (autowarefoundation#4800) cache ccache again Signed-off-by: Yutaka Kondo <[email protected]> * chore: hold check of plotjuggler-ros package and display warning if held (autowarefoundation#4805) * chore: Hold check of plotjuggler-ros package and display warning if held Signed-off-by: Naophis <[email protected]> * chore: fix condition for checking held ROS package in dev_tools role Signed-off-by: Naophis <[email protected]> * style(pre-commit): autofix * chore: Update dev_tools role to fix condition for checking held ROS package Signed-off-by: Naophis <[email protected]> --------- Signed-off-by: Naophis <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(docker): revert "cache apt archives to the Docker build cache" (autowarefoundation#4793) Revert "feat(docker): cache apt archives to the Docker build cache (autowarefoundation#4778)" Signed-off-by: Yutaka Kondo <[email protected]> * chore(ci): add a workflow for DCO check to avoid DCO bot system failure (autowarefoundation#4825) Signed-off-by: Ryohsuke Mitsudome <[email protected]> * feat(ci): add CPU architecture suffixes to the Docker build cache (autowarefoundation#4826) * add arch prefix Signed-off-by: Yutaka Kondo <[email protected]> * rename Signed-off-by: Yutaka Kondo <[email protected]> * use lib_dir Signed-off-by: Yutaka Kondo <[email protected]> * change suffix Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(simulator.repos): use autoware_msgs_support branch for scenario_simulator (autowarefoundation#4823) Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Yutaka Kondo <[email protected]> * feat(ansible): add lidar_transfusion artifacts (autowarefoundation#4835) * refactor(docker): fix colcon `--cmake-args` (autowarefoundation#4828) fix colcon cmake-args Signed-off-by: Yutaka Kondo <[email protected]> * refactor(ci): use platform arg to replace raw string (autowarefoundation#4844) use platform arg to replace raw string Signed-off-by: Yutaka Kondo <[email protected]> * refactor(ci): install `vcstool` and run `vcs import` on `docker-build-and-push.yaml` (autowarefoundation#4845) * refactor docker-build-and-push Signed-off-by: Yutaka Kondo <[email protected]> * fix shell Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> Co-authored-by: oguzkaganozt <[email protected]> * fix platform Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: Ryohsuke Mitsudome <[email protected]> Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: Naophis <[email protected]> Signed-off-by: M. Fatih Cırıt <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: badai nguyen <[email protected]> Co-authored-by: Naophis <[email protected]> Co-authored-by: M. Fatih Cırıt <[email protected]> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Amadeusz Szymko <[email protected]> Co-authored-by: oguzkaganozt <[email protected]>

…eld (autowarefoundation#4805) * chore: Hold check of plotjuggler-ros package and display warning if held Signed-off-by: Naophis <[email protected]> * chore: fix condition for checking held ROS package in dev_tools role Signed-off-by: Naophis <[email protected]> * style(pre-commit): autofix * chore: Update dev_tools role to fix condition for checking held ROS package Signed-off-by: Naophis <[email protected]> --------- Signed-off-by: Naophis <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Naophis added 2 commits June 3, 2024 14:33

chore: Hold check of plotjuggler-ros package and display warning if held

15fb558

Signed-off-by: Naophis <[email protected]>

chore: fix condition for checking held ROS package in dev_tools role

fc9b58e

Signed-off-by: Naophis <[email protected]>

Naophis requested review from oguzkaganozt and youtalk as code owners June 3, 2024 06:05

style(pre-commit): autofix

ef235eb

Naophis requested a review from mitsudome-r June 3, 2024 06:07

mitsudome-r approved these changes Jun 3, 2024

View reviewed changes

chore: Update dev_tools role to fix condition for checking held ROS p…

dfe18f4

…ackage Signed-off-by: Naophis <[email protected]>

mitsudome-r merged commit c707661 into autowarefoundation:main Jun 3, 2024
13 checks passed

Naophis deleted the chore/escape_hold_package_install branch June 3, 2024 08:36

tier4-autoware-public-bot bot mentioned this pull request Jun 4, 2024

chore: sync upstream tier4/autoware#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: hold check of plotjuggler-ros package and display warning if held #4805

chore: hold check of plotjuggler-ros package and display warning if held #4805

Naophis commented Jun 3, 2024

chore: hold check of plotjuggler-ros package and display warning if held #4805

chore: hold check of plotjuggler-ros package and display warning if held #4805

Conversation

Naophis commented Jun 3, 2024

Description

Tests performed

premise

before

after(held packages)

after (not held packages)

after(initial setup)

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author