Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-main): update for openadk #4528

Merged
merged 3 commits into from
Mar 8, 2024
Merged

ci(build-main): update for openadk #4528

merged 3 commits into from
Mar 8, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Mar 8, 2024

Description

Fixes:

cc. @HansRobo

Tests performed

❌ they didn't build as well. Probably the conditions / parameters for actions/docker-build-and-push/action.yaml needs to be fixed.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx requested a review from oguzkaganozt March 8, 2024 07:56
Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx xmfcx merged commit 5519784 into main Mar 8, 2024
18 of 19 checks passed
@xmfcx xmfcx deleted the ci/fix-build-main branch March 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants