CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.32 (3.83 -> 4.15)
- Declining Code Health: 11 findings(s) 🚩
- Improving Code Health: 12 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method goal_planner_module.cpp: LaneParkingPlanner::onTimer 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::updateData 🔥
- Complex Method goal_planner_module.cpp: FreespaceParkingPlanner::onTimer 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::planPullOverAsOutput 🔥
- Complex Method goal_planner_module.cpp: FreespaceParkingPlanner::isStuck 🔥
- Complex Method goal_planner_module.cpp: LaneParkingPlanner::LaneParkingPlanner 🔥
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::updateData 🔥
- Bumpy Road Ahead goal_planner_module.cpp: LaneParkingPlanner::onTimer 🔥
- Excess Number of Function Arguments thread_data.cpp: LaneParkingRequest::update
- Excess Number of Function Arguments thread_data.cpp: FreespaceParkingRequest::update
- Bumpy Road Ahead goal_planner_module.cpp: FreespaceParkingPlanner::onTimer 🔥
✅ Improving Code Health:
- Lines of Code in a Single File goal_planner_module.cpp 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::onTimer 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::onFreespaceParkingTimer 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::isStuck 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::generateStopPath 🔥
- Deep, Nested Complexity goal_planner_module.cpp: GoalPlannerModule::onTimer 🔥
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::onTimer 🔥
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::onFreespaceParkingTimer 🔥
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::onTimer 🔥
- Excess Number of Function Arguments goal_planner_module.cpp: GoalPlannerModule::planFreespacePath 🔥
- Excess Number of Function Arguments goal_planner_module.cpp: GoalPlannerModule::isStuck 🔥
- Excess Number of Function Arguments goal_planner_module.cpp: GoalPlannerModule::GoalPlannerData::update 🔥
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1872 to 1865, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
GoalPlannerModule::updateData increases in cyclomatic complexity from 15 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
GoalPlannerModule::planPullOverAsOutput increases in cyclomatic complexity from 13 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
GoalPlannerModule::generateStopPath decreases in cyclomatic complexity from 14 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::onTimer is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::onFreespaceParkingTimer is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::isStuck is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
LaneParkingPlanner::onTimer has a cyclomatic complexity of 29, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
FreespaceParkingPlanner::onTimer has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
FreespaceParkingPlanner::isStuck has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
LaneParkingPlanner::LaneParkingPlanner has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
GoalPlannerModule::onTimer no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
GoalPlannerModule::onFreespaceParkingTimer no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Conditional
FreespaceParkingPlanner::onTimer has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Bumpy Road Ahead
GoalPlannerModule::updateData increases from 2 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
GoalPlannerModule::onTimer is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
LaneParkingPlanner::onTimer has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
FreespaceParkingPlanner::onTimer has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 6.38 to 6.54, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Deep, Nested Complexity
GoalPlannerModule::onTimer is no longer above the threshold for nested complexity depth. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Deep, Nested Complexity
LaneParkingPlanner::onTimer has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GoalPlannerModule::planFreespacePath is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GoalPlannerModule::isStuck is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GoalPlannerModule::GoalPlannerData::update is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
LaneParkingRequest::update has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.