Skip to content
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 13, 2024 in 34s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 8 findings(s) βœ…

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Bumpy Road Ahead bicycle_tracker.cpp: BicycleTracker::getUpdatingObject

βœ… Improving Code Health:

  • Large Method normal_vehicle_tracker.cpp: NormalVehicleTracker::NormalVehicleTracker
  • Large Method big_vehicle_tracker.cpp: BigVehicleTracker::BigVehicleTracker
  • Large Method bicycle_tracker.cpp: BicycleTracker::BicycleTracker
  • Large Method pedestrian_tracker.cpp: PedestrianTracker::PedestrianTracker
  • Large Method unknown_tracker.cpp: UnknownTracker::UnknownTracker
  • Overall Code Complexity big_vehicle_tracker.cpp
  • Overall Code Complexity normal_vehicle_tracker.cpp
  • Complex Conditional pedestrian_tracker.cpp: PedestrianTracker::measureWithShape

Annotations

Check notice on line 136 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Large Method

BicycleTracker::BicycleTracker decreases from 95 to 79 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 195 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

BicycleTracker::getUpdatingObject has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 152 in perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Large Method

BigVehicleTracker::BigVehicleTracker decreases from 109 to 91 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… No longer an issue: Overall Code Complexity

The mean cyclomatic complexity in this module is no longer above the threshold

Check notice on line 153 in perception/multi_object_tracker/src/tracker/model/normal_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Large Method

NormalVehicleTracker::NormalVehicleTracker decreases from 110 to 92 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/multi_object_tracker/src/tracker/model/normal_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… No longer an issue: Overall Code Complexity

The mean cyclomatic complexity in this module is no longer above the threshold

Check notice on line 135 in perception/multi_object_tracker/src/tracker/model/pedestrian_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Large Method

PedestrianTracker::PedestrianTracker decreases from 90 to 78 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/multi_object_tracker/src/tracker/model/pedestrian_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

β„Ή Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 4.57 to 4.71, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 227 in perception/multi_object_tracker/src/tracker/model/pedestrian_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… No longer an issue: Complex Conditional

PedestrianTracker::measureWithShape no longer has a complex conditional

Check notice on line 130 in perception/multi_object_tracker/src/tracker/model/unknown_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Large Method

UnknownTracker::UnknownTracker decreases from 78 to 77 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.