Skip to content

feat(behavior_path_planner): replace polling subscribers

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 11, 2024 in 37s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 1 findings(s) βœ…

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Overall Code Complexity behavior_path_planner_node.cpp
  • Complex Method behavior_path_planner_node.cpp: BehaviorPathPlannerNode::takeData

βœ… Improving Code Health:

  • Large Method behavior_path_planner_node.cpp: BehaviorPathPlannerNode::BehaviorPathPlannerNode

Annotations

Check warning on line 307 in planning/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

BehaviorPathPlannerNode::takeData has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 66 in planning/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… No longer an issue: Large Method

BehaviorPathPlannerNode::BehaviorPathPlannerNode is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 1 in planning/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.95 across 21 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.