Skip to content

modify ring outlier filter node for supporting counter clockwise azimuth

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 14, 2024 in 39s

CodeScene PR Check

βœ… Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) βœ…
  • Affected Hotspots: 0 files(s) πŸ”₯

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method distortion_corrector.cpp: DistortionCorrectorComponent::undistortPointCloud

Annotations

Check warning on line 321 in sensing/pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

DistortionCorrectorComponent::undistortPointCloud increases in cyclomatic complexity from 21 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.