Skip to content

refactor(start_planner): add verbose parameter for debug print

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 17, 2023 in 1m 0s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 3 findings(s) 🚩
  • Improving Code Health: 0 findings(s) βœ…
  • Affected Hotspots: 1 files(s) πŸ”₯

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method manager.cpp: StartPlannerModuleManager::StartPlannerModuleManager
  • Lines of Code in a Single File start_planner_module.cpp πŸ”₯
  • Complex Method start_planner_module.cpp: StartPlannerModule::logPullOutStatus πŸ”₯

Annotations

Check warning on line 36 in planning/behavior_path_planner/src/scene_module/start_planner/manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

StartPlannerModuleManager::StartPlannerModuleManager increases from 233 to 234 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 1 in planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Lines of Code in a Single File

This module has 1034 lines of code, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 1371 in planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

StartPlannerModule::logPullOutStatus has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.