Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_camera_view_rviz_plugin): fix bugprone-parent-virtual-call #9815

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix(tier4_camera_view_rviz_plugin): fix bugprone-parent-virtual-call #9815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7b27a8
fix:bugprone-error
kobayu858 Dec 27, 2024
7e4a7de
fix:fmt
kobayu858 Dec 27, 2024
cae846f
Merge branch 'main' into clang-tidy-b8
kobayu858 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion visualization/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@

void ThirdPersonViewController::mimic(rviz_common::ViewController * source_view)
{
FramePositionTrackingViewController::mimic(source_view);
FramePositionTrackingViewController::mimic(source_view); // NOLINT

Check warning on line 187 in visualization/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp

View check run for this annotation

Codecov / codecov/patch

visualization/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp#L187 

Added line #L187 was not covered by tests

target_frame_property_->setValue(TARGET_FRAME_START);
getNewTransform();
Expand Down
Loading