Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix usage of last_previous_module_output #9811

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Dec 27, 2024

Description

  • rename previous_module_output to upstream_module_output
  • save last_upsream_module_output in LaneParkingPlanner as the upsream_module_output used for generating pull over path candidates

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 27, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin marked this pull request as ready for review December 27, 2024 05:56
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 28.75%. Comparing base (7e3a80c) to head (e009a58).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 21 Missing ⚠️
..._module/src/pull_over_planner/bezier_pull_over.cpp 0.00% 4 Missing ⚠️
...th_goal_planner_module/fixed_goal_planner_base.hpp 0.00% 2 Missing ⚠️
.../behavior_path_goal_planner_module/thread_data.hpp 0.00% 2 Missing ⚠️
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 2 Missing ⚠️
...avior_path_goal_planner_module/src/thread_data.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9811      +/-   ##
==========================================
- Coverage   28.77%   28.75%   -0.02%     
==========================================
  Files        1456     1460       +4     
  Lines      109101   109168      +67     
  Branches    42498    42499       +1     
==========================================
  Hits        31394    31394              
- Misses      74631    74697      +66     
- Partials     3076     3077       +1     
Flag Coverage Δ *Carryforward flag
differential 0.51% <0.00%> (?)
total 28.78% <ø> (+<0.01%) ⬆️ Carriedforward from 7e3a80c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 58df2a1 into autowarefoundation:main Dec 31, 2024
49 of 52 checks passed
@soblin soblin deleted the fix/goal-planner-path-update branch December 31, 2024 11:26
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants