-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): add text display for candidate path sampling metrics #9810
feat(lane_change): add text display for candidate path sampling metrics #9810
Conversation
Signed-off-by: mohammad alqudah <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9810 +/- ##
==========================================
- Coverage 30.08% 30.07% -0.01%
==========================================
Files 1451 1453 +2
Lines 108854 108911 +57
Branches 42744 42765 +21
==========================================
+ Hits 32752 32759 +7
- Misses 72900 72950 +50
Partials 3202 3202
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
namespace autoware::behavior_path_planner::lane_change | ||
{ | ||
using utils::path_safety_checker::CollisionCheckDebugMap; | ||
|
||
struct LaneChangeMetricsDebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already in the lane change namespace, so do we still need the "LaneChange" in the struct name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm true maybe PhaseMetricsDebug
?
I was thinking to have "Accepted" and "Rejected" status for indication. How do you think about it? |
I will need to slightly refactor the current implementation in order to do that. But it's possible, so I will do it in another PR, I would like to merge this one for now to include it in the debugging document |
Signed-off-by: mohammad alqudah <[email protected]>
…cs (autowarefoundation#9810) * display candidate path sampling metrics on rviz Signed-off-by: mohammad alqudah <[email protected]> * rename struct Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
…cs (autowarefoundation#9810) * display candidate path sampling metrics on rviz Signed-off-by: mohammad alqudah <[email protected]> * rename struct Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
Description
Display candidate path sampling metrics for prepare phase and lane changing phase on rviz to help with debugging.
Related links
None.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.