Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): add text display for candidate path sampling metrics #9810

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Dec 27, 2024

Description

Display candidate path sampling metrics for prepare phase and lane changing phase on rviz to help with debugging.

Screenshot from 2024-12-27 11-01-01

Related links

None.

How was this PR tested?

  • PSIM

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 27, 2024
Copy link

github-actions bot commented Dec 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 30.07%. Comparing base (1586372) to head (6e4f641).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...vior_path_lane_change_module/src/utils/markers.cpp 8.00% 22 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9810      +/-   ##
==========================================
- Coverage   30.08%   30.07%   -0.01%     
==========================================
  Files        1451     1453       +2     
  Lines      108854   108911      +57     
  Branches    42744    42765      +21     
==========================================
+ Hits        32752    32759       +7     
- Misses      72900    72950      +50     
  Partials     3202     3202              
Flag Coverage Δ *Carryforward flag
differential 20.89% <17.85%> (?)
total 30.08% <ø> (ø) Carriedforward from 2a9300e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


namespace autoware::behavior_path_planner::lane_change
{
using utils::path_safety_checker::CollisionCheckDebugMap;

struct LaneChangeMetricsDebug
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the lane change namespace, so do we still need the "LaneChange" in the struct name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm true maybe PhaseMetricsDebug ?

@zulfaqar-azmi-t4
Copy link
Contributor

zulfaqar-azmi-t4 commented Dec 27, 2024

I was thinking to have "Accepted" and "Rejected" status for indication. How do you think about it?

@mkquda
Copy link
Contributor Author

mkquda commented Dec 27, 2024

I was thinking to have "Accepted" and "Rejected" status for indication. How do you think about it?

I will need to slightly refactor the current implementation in order to do that. But it's possible, so I will do it in another PR, I would like to merge this one for now to include it in the debugging document

Signed-off-by: mohammad alqudah <[email protected]>
@mkquda mkquda enabled auto-merge (squash) December 27, 2024 06:14
@mkquda mkquda merged commit f211728 into autowarefoundation:main Dec 27, 2024
36 checks passed
@mkquda mkquda deleted the RT1-8925-display-lane-change-metrics-for-debugging branch December 27, 2024 06:38
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
…cs (autowarefoundation#9810)

* display candidate path sampling metrics on rviz

Signed-off-by: mohammad alqudah <[email protected]>

* rename struct

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
…cs (autowarefoundation#9810)

* display candidate path sampling metrics on rviz

Signed-off-by: mohammad alqudah <[email protected]>

* rename struct

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants