Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): remove virtual traffic light dependency from behavior_velocity_planner and behavior_velocity_planner_common #9746

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 23, 2024

Description

Currently, the virtual traffic light's variables in the behavior_velocity_planner/behavior_velocity_planner_common are very specific to the behavior_velocity_virtual_traffic_light_module and do not need to be shared in other modules.
Therefore, this PR moved the implementation related to the virtual traffic light from the behavior_velocity_planner/behavior_velocity_planner_common to the behavior_velocity_virtual_traffic_light_module.

Related links

How was this PR tested?

The unit test passed.
The psim worked as expected.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the feat/remove-virtual-traffic-light-dependency-from-plugin-manager branch 2 times, most recently from 6b54a98 to 32b8b07 Compare December 26, 2024 08:24
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 26, 2024
@takayuki5168 takayuki5168 force-pushed the feat/remove-virtual-traffic-light-dependency-from-plugin-manager branch from 32b8b07 to 383f6d2 Compare January 6, 2025 02:40
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jan 6, 2025
@takayuki5168 takayuki5168 force-pushed the feat/remove-virtual-traffic-light-dependency-from-plugin-manager branch 2 times, most recently from b159fd6 to 0d85022 Compare January 6, 2025 03:49
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2025
@takayuki5168 takayuki5168 marked this pull request as ready for review January 6, 2025 03:55
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/remove-virtual-traffic-light-dependency-from-plugin-manager branch from 0d85022 to 4521363 Compare January 6, 2025 03:56
@takayuki5168 takayuki5168 changed the title feat: remove-virtual-traffic-light-dependency-from-plugin-manager feat(behavior_velocity_planner): remove virtual traffic light dependency from behavior_velocity_planner and behavior_velocity_planner_common Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (176e2e3) to head (4521363).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...elocity_virtual_traffic_light_module/src/scene.cpp 0.00% 8 Missing ⚠️
...ocity_virtual_traffic_light_module/src/manager.cpp 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9746      +/-   ##
==========================================
- Coverage   29.61%   29.60%   -0.02%     
==========================================
  Files        1451     1456       +5     
  Lines      108896   108958      +62     
  Branches    42587    42595       +8     
==========================================
+ Hits        32249    32254       +5     
- Misses      73550    73606      +56     
- Partials     3097     3098       +1     
Flag Coverage Δ *Carryforward flag
differential 22.29% <40.90%> (?)
total 29.61% <ø> (-0.01%) ⬇️ Carriedforward from 176e2e3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takayuki5168 takayuki5168 merged commit 7fb4c1b into autowarefoundation:main Jan 6, 2025
42 checks passed
@takayuki5168 takayuki5168 deleted the feat/remove-virtual-traffic-light-dependency-from-plugin-manager branch January 6, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants