-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): remove virtual traffic light dependency from behavior_velocity_planner and behavior_velocity_planner_common #9746
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
6b54a98
to
32b8b07
Compare
32b8b07
to
383f6d2
Compare
b159fd6
to
0d85022
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
0d85022
to
4521363
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9746 +/- ##
==========================================
- Coverage 29.61% 29.60% -0.02%
==========================================
Files 1451 1456 +5
Lines 108896 108958 +62
Branches 42587 42595 +8
==========================================
+ Hits 32249 32254 +5
- Misses 73550 73606 +56
- Partials 3097 3098 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Currently, the virtual traffic light's variables in the
behavior_velocity_planner/behavior_velocity_planner_common
are very specific to thebehavior_velocity_virtual_traffic_light_module
and do not need to be shared in other modules.Therefore, this PR moved the implementation related to the virtual traffic light from the
behavior_velocity_planner/behavior_velocity_planner_common
to thebehavior_velocity_virtual_traffic_light_module
.Related links
How was this PR tested?
The unit test passed.
The psim worked as expected.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.