feat(pid_longitudinal_controller): add new slope compensation mode trajectory_goal_adaptive #9705
+30
−12
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Dec 20, 2024 in 32s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.02 (5.82 -> 5.80)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method pid_longitudinal_controller.cpp: PidLongitudinalController::getControlData
✅ Improving Code Health:
- Large Method pid_longitudinal_controller.cpp: PidLongitudinalController::getControlData
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
PidLongitudinalController::getControlData has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
PidLongitudinalController::getControlData is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.44 to 4.59, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading