Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): divide sort function #9650

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Dec 15, 2024

Description

divide pull over path candidates sort functionality to a utility function.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 15, 2024
Copy link

github-actions bot commented Dec 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the refactor/goal-planner/divide-sort branch from 30dff65 to c7b5c87 Compare December 15, 2024 21:51
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 29.80%. Comparing base (5ced41e) to head (81d7e3d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9650      +/-   ##
==========================================
- Coverage   29.82%   29.80%   -0.02%     
==========================================
  Files        1443     1448       +5     
  Lines      108539   108609      +70     
  Branches    42581    42583       +2     
==========================================
  Hits        32376    32376              
- Misses      72983    73053      +70     
  Partials     3180     3180              
Flag Coverage Δ *Carryforward flag
differential 0.52% <0.00%> (?)
total 29.83% <ø> (+<0.01%) ⬆️ Carriedforward from 5ced41e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin force-pushed the refactor/goal-planner/divide-sort branch from c7b5c87 to 81d7e3d Compare December 15, 2024 23:24
@soblin soblin merged commit 9ee2c5a into autowarefoundation:main Dec 16, 2024
34 of 35 checks passed
@soblin soblin deleted the refactor/goal-planner/divide-sort branch December 16, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants