-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planner): add bezier based pull over planner #9642
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4b10c86
to
0767098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to the autoware_bezier_sampler
look good.
double distance_initial_to_final = std::sqrt( | ||
(initial.pose.x() - final.pose.x()) * (initial.pose.x() - final.pose.x()) + | ||
(initial.pose.y() - final.pose.y()) * (initial.pose.y() - final.pose.y())); | ||
// Tangent vectors | ||
const Eigen::Vector2d initial_tangent_unit(std::cos(initial.heading), std::sin(initial.heading)); | ||
const Eigen::Vector2d final_tangent_unit(std::cos(final.heading), std::sin(final.heading)); | ||
// Unit vectors | ||
const Eigen::Vector2d initial_normal_unit = initial_tangent_unit.unitOrthogonal(); | ||
const Eigen::Vector2d final_normal_unit = final_tangent_unit.unitOrthogonal(); | ||
double initial_tangent_length = initial_velocity * distance_initial_to_final; | ||
double final_tangent_length = final_velocity * distance_initial_to_final; | ||
double acceleration_length = acceleration * distance_initial_to_final; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything can be made const
here.
double distance_initial_to_final = std::sqrt( | |
(initial.pose.x() - final.pose.x()) * (initial.pose.x() - final.pose.x()) + | |
(initial.pose.y() - final.pose.y()) * (initial.pose.y() - final.pose.y())); | |
// Tangent vectors | |
const Eigen::Vector2d initial_tangent_unit(std::cos(initial.heading), std::sin(initial.heading)); | |
const Eigen::Vector2d final_tangent_unit(std::cos(final.heading), std::sin(final.heading)); | |
// Unit vectors | |
const Eigen::Vector2d initial_normal_unit = initial_tangent_unit.unitOrthogonal(); | |
const Eigen::Vector2d final_normal_unit = final_tangent_unit.unitOrthogonal(); | |
double initial_tangent_length = initial_velocity * distance_initial_to_final; | |
double final_tangent_length = final_velocity * distance_initial_to_final; | |
double acceleration_length = acceleration * distance_initial_to_final; | |
const double distance_initial_to_final = std::sqrt( | |
(initial.pose.x() - final.pose.x()) * (initial.pose.x() - final.pose.x()) + | |
(initial.pose.y() - final.pose.y()) * (initial.pose.y() - final.pose.y())); | |
// Tangent vectors | |
const Eigen::Vector2d initial_tangent_unit(std::cos(initial.heading), std::sin(initial.heading)); | |
const Eigen::Vector2d final_tangent_unit(std::cos(final.heading), std::sin(final.heading)); | |
// Unit vectors | |
const Eigen::Vector2d initial_normal_unit = initial_tangent_unit.unitOrthogonal(); | |
const Eigen::Vector2d final_normal_unit = final_tangent_unit.unitOrthogonal(); | |
const double initial_tangent_length = initial_velocity * distance_initial_to_final; | |
const double final_tangent_length = final_velocity * distance_initial_to_final; | |
const double acceleration_length = acceleration * distance_initial_to_final; |
4b8400f
to
1548a30
Compare
...lanner/autoware_behavior_path_goal_planner_module/src/pull_over_planner/bezier_pull_over.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mamoru Sobue <[email protected]>
… with bezier Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
96f632d
to
21346a5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9642 +/- ##
==========================================
- Coverage 29.90% 29.84% -0.06%
==========================================
Files 1441 1448 +7
Lines 108349 108575 +226
Branches 42492 42584 +92
==========================================
+ Hits 32403 32407 +4
- Misses 72763 72977 +214
- Partials 3183 3191 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <[email protected]>
Description
ros2 run autoware_behavior_path_goal_planner plot_map{1, 2} gives following figures.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.