-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_multi_object_tracker): add configurable tracker parameters #9621
refactor(autoware_multi_object_tracker): add configurable tracker parameters #9621
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakor97 Thank you for your contribution.
Those are the parameters may someone want to configure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update multi_object_tracker_node.schema.json?
perception/autoware_multi_object_tracker/src/multi_object_tracker_node.cpp
Outdated
Show resolved
Hide resolved
…ameters Signed-off-by: jkoronczok <[email protected]>
…arameter declarations Signed-off-by: jkoronczok <[email protected]>
Signed-off-by: jkoronczok <[email protected]>
986a0e4
to
bf7c213
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these fixes, LGTM
I would like to approve it after the fix.
perception/autoware_multi_object_tracker/src/processor/processor.cpp
Outdated
Show resolved
Hide resolved
perception/autoware_multi_object_tracker/src/processor/processor.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9621 +/- ##
==========================================
- Coverage 29.61% 29.61% -0.01%
==========================================
Files 1440 1440
Lines 108348 108363 +15
Branches 41384 41388 +4
==========================================
Hits 32088 32088
- Misses 73148 73163 +15
Partials 3112 3112
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Extracted
autoware_multi_object_tracker
parameters from source code, refactored parameters declaration and enabled settingconfident_count_threshold
for each classification label separately.Changes
tracker_lifetime
,min_known_object_removal_iou
,min_unknown_object_removal_iou
,distance_threshold
, andconfident_count_threshold
to themulti_object_tracker_node.param.yaml
configuration file.TrackerProcessorConfig
struct to encapsulate tracker-related parameters and refactored theTrackerProcessor
class to use this struct for initialization.TrackerProcessor
methods to use the new configuration struct, includingcreateNewTracker
,removeOldTracker
,removeOverlappedTracker
, andisConfidentTracker
.Related links
autowarefoundation/autoware_launch#1273
autoware_launch
PR for according parameters.How was this PR tested?
Build completed successfully.
Tested parameters changes in Carla environment.
Notes for reviewers
None.
ROS Parameter Changes
Extracted parameters from source code and renamed them according to their use:
max_elapsed_time_
tracker_lifetime
min_iou_
min_known_object_removal_iou
min_iou_for_unknown_object_
min_unknown_object_removal_iou
distance_threshold_
distance_threshold
confident_count_threshold_
confident_count_threshold
for each label typeAdditions and removals
tracker_lifetime
float
1.0
min_known_object_removal_iou
float
0.1
min_unknown_object_removal_iou
float
0.001
distance_threshold
float
5.0
confident_count_threshold
std::map<std::string, LabelType>
Label : 3
Effects on system behavior
None.