-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_centerpoint, pointpainting)!: move max_voxel_count from _ml_package.param.yaml #9578
base: main
Are you sure you want to change the base?
feat(lidar_centerpoint, pointpainting)!: move max_voxel_count from _ml_package.param.yaml #9578
Conversation
…_package.param.yaml Signed-off-by: kminoda <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9578 +/- ##
==========================================
- Coverage 29.37% 29.37% -0.01%
==========================================
Files 1446 1447 +1
Lines 108400 108408 +8
Branches 42236 42232 -4
==========================================
+ Hits 31844 31846 +2
- Misses 73472 73478 +6
Partials 3084 3084
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <[email protected]>
Description
Since
max_voxel_count
is likely to be tuned for each vehicle / environment, I would like to move this parameter from*_ml_package.param.yaml
to*.param.yaml
.Related links
Must be merged with autowarefoundation/autoware_launch#1258
How was this PR tested?
Works for centerpoint
Works for pointpainting
Notes for reviewers
None.
Interface changes
Modifications
model_params.max_voxel_count
max_voxel_count
To TIER IV members:
This PR will be a breaking change for ML models. Please contact the perception team in TIER IV for a proper update of ML models in Web.Auto.
For pointpainting, please use this model: https://evaluation.tier4.jp/evaluation/mlpackages/5b56c824-de65-406e-b12f-d7271589cc70/releases/cfe1a125-84d0-42b2-845c-c03efe896d3e?project_id=zWhWRzei&tab=reports
For centerpoint, please use
base/2.0
and the latter versionEffects on system behavior
None.