Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): move unnecessary member functions #9522

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 29, 2024

Description

for achieving #9514

some member functions do not need to be member function, so move them to free functions,

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the refactor/goal-planner/move-unnecessary-memfn branch from e81a3a9 to af0316b Compare November 29, 2024 03:15
@soblin soblin marked this pull request as ready for review November 29, 2024 08:56
@soblin soblin requested a review from kosuke55 November 29, 2024 08:58
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 2, 2024
@soblin soblin enabled auto-merge (squash) December 2, 2024 02:25
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 29.46%. Comparing base (c1bbd68) to head (af0316b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9522      +/-   ##
==========================================
- Coverage   29.47%   29.46%   -0.02%     
==========================================
  Files        1440     1445       +5     
  Lines      108556   108610      +54     
  Branches    41499    41501       +2     
==========================================
  Hits        32001    32001              
- Misses      73443    73496      +53     
- Partials     3112     3113       +1     
Flag Coverage Δ *Carryforward flag
differential 0.52% <0.00%> (?)
total 29.49% <ø> (+0.01%) ⬆️ Carriedforward from c1bbd68

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 815abd9 into autowarefoundation:main Dec 2, 2024
43 of 44 checks passed
@soblin soblin deleted the refactor/goal-planner/move-unnecessary-memfn branch December 2, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants