chore: move rviz plugins from common to visualization/ folder #9417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
esteve
force-pushed
the
move-rviz-plugins
branch
from
dff9d31 to
652f800
Compare
Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
move-rviz-plugins
branch
from
652f800 to
9502f9a
Compare
|
@xmfcx this simply moves the rviz plugins to the visualization folder, there are no code changes. After this PR gets merged, I'll trigger an update of CODEOWNERS file via the corresponding GH action. |
xmfcx
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9417 +/- ##
==========================================
- Coverage 29.59% 27.93% -1.67%
==========================================
Files 1442 1512 +70
Lines 108512 114960 +6448
Branches 41409 41886 +477
==========================================
Hits 32119 32119
- Misses 73269 79717 +6448
Partials 3124 3124
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
rvizplugins from comon to its ownvisualization/folder so that creating Docker images for onlycommonis easier.Related links
Parent Issue:
autoware.universe/commonpackages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.