Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(global_parameter_loader): prefix package and namespace with autoware #9303

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 12, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve enabled auto-merge (squash) November 12, 2024 12:24
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the prefix-global_parameter_loader branch from 87610e4 to 6dcf282 Compare November 12, 2024 12:25
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Nov 12, 2024
@esteve esteve force-pushed the prefix-global_parameter_loader branch 2 times, most recently from c6f2e72 to 2b3380d Compare November 13, 2024 14:30
@esteve esteve self-assigned this Nov 13, 2024
@esteve esteve force-pushed the prefix-global_parameter_loader branch from 2b3380d to cce63b1 Compare November 18, 2024 10:31
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.73%. Comparing base (ed133eb) to head (2ee8f34).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9303      +/-   ##
==========================================
- Coverage   29.51%   28.73%   -0.78%     
==========================================
  Files        1446     1353      -93     
  Lines      108518   106201    -2317     
  Branches    41396    40877     -519     
==========================================
- Hits        32025    30517    -1508     
+ Misses      73372    72717     -655     
+ Partials     3121     2967     -154     
Flag Coverage Δ *Carryforward flag
differential 10.50% <ø> (?)
total 29.58% <ø> (+0.07%) ⬆️ Carriedforward from fd9d33e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@mitsudome-r could you review (and merge) this PR when you have time? Thanks.

@xmfcx xmfcx changed the title chore(global_parameter_loader): prefix package and namespace with autoware refactor(global_parameter_loader): prefix package and namespace with autoware Nov 20, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024

Searching the global_parameter_loader within the autoware directory, there are repositories that contain references to this package that needs to be updated:

Repository Reference to global_parameter_loader
autowarefoundation/autoware_tools Search Results
autowarefoundation/autoware_launch Search Results
tier4/pacmod_interface Search Results

@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@xmfcx thanks for the review, I'm moving this back to draft to address your feedback.

@esteve esteve marked this pull request as draft November 20, 2024 11:40
auto-merge was automatically disabled November 20, 2024 11:40

Pull request was converted to draft

@esteve esteve changed the title refactor(global_parameter_loader): prefix package and namespace with autoware chore(global_parameter_loader): prefix package and namespace with autoware Nov 20, 2024
@xmfcx xmfcx changed the title chore(global_parameter_loader): prefix package and namespace with autoware refactor(global_parameter_loader): prefix package and namespace with autoware Nov 20, 2024
@esteve esteve marked this pull request as ready for review November 25, 2024 10:23
@esteve
Copy link
Contributor Author

esteve commented Nov 25, 2024

@mitsudome-r @xmfcx the other three PRs have been approved, should all four PRs be merged now? Thanks.

@esteve esteve enabled auto-merge (squash) November 26, 2024 13:28
@mitsudome-r
Copy link
Member

I will check locally with planning-simulator if this modification doesn't cause any issue and will merge the PR.

@esteve esteve disabled auto-merge December 4, 2024 12:29
@xmfcx xmfcx self-requested a review December 4, 2024 13:21
@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

image

I was able to drive autonomously with AWSIM-Labs with the latest autoware nightly repos, with all the sub-PRs rebased and checked out to main. ✅

Thanks for your efforts!

@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

Also manually checked the usage of global_parameter_loader throughout the repository and checking them visually, they all seemed to have been prefixed correctly ✅

@esteve
Copy link
Contributor Author

esteve commented Dec 4, 2024

@xmfcx whenever you think it's ok, we can merge this and the other PRs. Thanks for taking the time to review all these changes, much appreciated 🙏

@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

Thank you a lot as well @esteve 💫

I'm now waiting for the CI in here to be finished. Then I will merge:

@xmfcx xmfcx merged commit 53691e4 into autowarefoundation:main Dec 4, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants