-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(global_parameter_loader): prefix package and namespace with autoware #9303
refactor(global_parameter_loader): prefix package and namespace with autoware #9303
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
87610e4
to
6dcf282
Compare
c6f2e72
to
2b3380d
Compare
2b3380d
to
cce63b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9303 +/- ##
==========================================
- Coverage 29.51% 28.73% -0.78%
==========================================
Files 1446 1353 -93
Lines 108518 106201 -2317
Branches 41396 40877 -519
==========================================
- Hits 32025 30517 -1508
+ Misses 73372 72717 -655
+ Partials 3121 2967 -154
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mitsudome-r could you review (and merge) this PR when you have time? Thanks. |
Searching the
|
@xmfcx thanks for the review, I'm moving this back to draft to address your feedback. |
Pull request was converted to draft
…autoware Signed-off-by: Esteve Fernandez <[email protected]>
cce63b1
to
fd9d33e
Compare
@xmfcx I've submitted these PR to update other repositories: |
@mitsudome-r @xmfcx the other three PRs have been approved, should all four PRs be merged now? Thanks. |
I will check locally with planning-simulator if this modification doesn't cause any issue and will merge the PR. |
Also manually checked the usage of |
@xmfcx whenever you think it's ok, we can merge this and the other PRs. Thanks for taking the time to review all these changes, much appreciated 🙏 |
Thank you a lot as well @esteve 💫 I'm now waiting for the CI in here to be finished. Then I will merge: |
Description
prefix package and namespace with
autoware
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.