Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(traffic_light_utils): prefix package and namespace with autoware #9251

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 6, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:require-cuda-build-and-test labels Nov 6, 2024
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 6, 2024
@esteve esteve force-pushed the prefix-traffic_light_utils branch 2 times, most recently from fd99f17 to 4718445 Compare November 12, 2024 11:43
@esteve esteve marked this pull request as ready for review November 12, 2024 11:44
@esteve esteve enabled auto-merge (squash) November 12, 2024 11:44
@esteve esteve self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 29.78%. Comparing base (24652f8) to head (e3216dc).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...are_traffic_light_occlusion_predictor/src/node.cpp 0.00% 3 Missing ⚠️
...h_planner_common/src/utils/traffic_light_utils.cpp 0.00% 2 Missing ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 1 Missing ⚠️
...city_out_of_lane_module/src/out_of_lane_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9251      +/-   ##
==========================================
- Coverage   29.78%   29.78%   -0.01%     
==========================================
  Files        1338     1343       +5     
  Lines      103302   103369      +67     
  Branches    40240    40253      +13     
==========================================
+ Hits        30770    30786      +16     
- Misses      69547    69597      +50     
- Partials     2985     2986       +1     
Flag Coverage Δ *Carryforward flag
differential 25.22% <0.00%> (?)
total 29.78% <ø> (+<0.01%) ⬆️ Carriedforward from 24652f8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the prefix-traffic_light_utils branch 2 times, most recently from 015669b to f9220b1 Compare November 13, 2024 14:32
@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@ktro2828 @maxime-clem thanks

@mitsudome-r @xmfcx could you merge this PR? @ktro2828 is a maintainer for this packages and he has approved the changes. Thanks.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 14, 2024

The CODEOWNERS is conflicting, could you fix it?

By the way, in these PRs, you don't need to manually update the CODEOWNERS files.

Instead, you can first merge the PR and then run https://github.com/autowarefoundation/autoware.universe/actions/workflows/update-codeowners-from-packages.yaml on the main and it will automatically create a PR to update them. And you can review that PR and merge it. (don't forget to add tag:run-build-and-test-differential)

image

Here is an example PR autogenerated by it:

You can find them under this tag:

@esteve esteve force-pushed the prefix-traffic_light_utils branch from f9220b1 to e3216dc Compare November 18, 2024 10:35
@esteve
Copy link
Contributor Author

esteve commented Nov 18, 2024

@xmfcx I've fixed the conflicts, thanks for the heads up about the autogenerated CODEOWNERS file, really useful.

@xmfcx xmfcx disabled auto-merge November 18, 2024 13:43
@xmfcx xmfcx merged commit f112f65 into autowarefoundation:main Nov 18, 2024
32 checks passed
@esteve esteve deleted the prefix-traffic_light_utils branch November 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants