Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_distance_calculator): prefix package and namespace with autoware #9172

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Oct 28, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve self-assigned this Oct 28, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Oct 28, 2024
@esteve esteve added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Oct 28, 2024
Copy link

github-actions bot commented Oct 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Oct 28, 2024
@esteve esteve marked this pull request as ready for review October 29, 2024 11:00
@esteve esteve requested a review from taikitanaka3 as a code owner October 29, 2024 11:00
@esteve esteve enabled auto-merge (squash) October 30, 2024 12:37
@esteve
Copy link
Contributor Author

esteve commented Oct 30, 2024

@taikitanaka3 could you have a look at these changes when you have a moment? Thanks 🙂

@esteve esteve force-pushed the prefix-goal_distance_calculator branch 2 times, most recently from 19d7244 to 807877f Compare October 30, 2024 12:39
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you

@esteve esteve force-pushed the prefix-goal_distance_calculator branch from 807877f to 9719408 Compare October 30, 2024 14:21
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Oct 30, 2024
@esteve
Copy link
Contributor Author

esteve commented Oct 30, 2024

@taikitanaka3 I've fixed an issue with the headers and also renamed the folder where goal_distance_calculator to have a prefix.

@esteve esteve merged commit b34d92c into autowarefoundation:main Oct 30, 2024
26 checks passed
@esteve esteve deleted the prefix-goal_distance_calculator branch October 30, 2024 14:26
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.73%. Comparing base (94b9ad0) to head (9719408).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e_calculator/src/goal_distance_calculator_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9172      +/-   ##
==========================================
- Coverage   28.74%   28.73%   -0.02%     
==========================================
  Files        1314     1317       +3     
  Lines      101743   101796      +53     
  Branches    39599    39609      +10     
==========================================
  Hits        29251    29251              
- Misses      69676    69729      +53     
  Partials     2816     2816              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.74% <ø> (ø) Carriedforward from 94b9ad0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants