fix(behavior_path_planner_common): swap boolean for filterObjectsByVelocity #9036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <[email protected]>
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
rej55,
maxime-clem,
TakaHoribe,
takayuki5168 and
zulfaqar-azmi-t4
as code owners
kyoichi-sugahara
approved these changes
Oct 4, 2024
go-sakayori
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9036 +/- ##
==========================================
- Coverage 26.52% 26.50% -0.02%
==========================================
Files 1296 1302 +6
Lines 95711 95755 +44
Branches 38974 38975 +1
==========================================
Hits 25383 25383
- Misses 67721 67765 +44
Partials 2607 2607
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
approved these changes
Oct 7, 2024
prakash-kannaiah
pushed a commit
to prakash-kannaiah/autoware.universe
that referenced
this pull request
Oct 9, 2024
…locity (autowarefoundation#9036) fix filter object by velocity Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: prakash-kannaiah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function
filterObjectsByVelocityhas an argumentremove_above_thresholdwhich is used to ignore the upper limit or not.The upper velocity limit would be ignored when the value is
falseand it might lead to misunderstanding.This PR swaps the condition, by ignoring the upper velocity limit when
remove_above_thresholdistrue.Related links
None
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.