Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lane_departure_checker): add tests for calcTrajectoryDeviation(), calcMaxSearchLengthForBoundaries() #9029

Conversation

mitukou1109
Copy link
Contributor

Description

This PR adds tests for calcTrajectoryDeviation, calcMaxSearchLengthForBoundaries in the autoware_lane_departure_checker package.

How was this PR tested?

colcon test --packages-select autoware_lane_departure_checker --event-handlers console_cohesion+

gives the following result:

1: [----------] 3 tests from LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest
1: [ RUN      ] LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest.test_calc_max_search_length_for_boundaries/EmptyTrajectory
1: [       OK ] LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest.test_calc_max_search_length_for_boundaries/EmptyTrajectory (1 ms)
1: [ RUN      ] LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest.test_calc_max_search_length_for_boundaries/SinglePointTrajectory
1: [       OK ] LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest.test_calc_max_search_length_for_boundaries/SinglePointTrajectory (0 ms)
1: [ RUN      ] LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest.test_calc_max_search_length_for_boundaries/MultiPointTrajectory
1: [       OK ] LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest.test_calc_max_search_length_for_boundaries/MultiPointTrajectory (0 ms)
1: [----------] 3 tests from LaneDepartureCheckerTest/CalcMaxSearchLengthForBoundariesTest (1 ms total)
1: 
1: [----------] 2 tests from LaneDepartureCheckerTest/CalcTrajectoryDeviationTest
1: [ RUN      ] LaneDepartureCheckerTest/CalcTrajectoryDeviationTest.test_calc_trajectory_deviation/EmptyTrajectory
1: [       OK ] LaneDepartureCheckerTest/CalcTrajectoryDeviationTest.test_calc_trajectory_deviation/EmptyTrajectory (0 ms)
1: [ RUN      ] LaneDepartureCheckerTest/CalcTrajectoryDeviationTest.test_calc_trajectory_deviation/SinglePointTrajectory
1: [       OK ] LaneDepartureCheckerTest/CalcTrajectoryDeviationTest.test_calc_trajectory_deviation/SinglePointTrajectory (0 ms)
1: [----------] 2 tests from LaneDepartureCheckerTest/CalcTrajectoryDeviationTest (0 ms total)

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 4, 2024
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.50%. Comparing base (959e57b) to head (5e1adef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._departure_checker_node/lane_departure_checker.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9029      +/-   ##
==========================================
- Coverage   29.50%   29.50%   -0.01%     
==========================================
  Files        1444     1450       +6     
  Lines      108519   108559      +40     
  Branches    41396    41396              
==========================================
+ Hits        32022    32033      +11     
- Misses      73377    73406      +29     
  Partials     3120     3120              
Flag Coverage Δ *Carryforward flag
differential 21.54% <83.33%> (?)
total 29.51% <ø> (+<0.01%) ⬆️ Carriedforward from 959e57b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and sorry for approving the PR 🙇

@kyoichi-sugahara kyoichi-sugahara merged commit 2a50825 into autowarefoundation:main Dec 3, 2024
42 checks passed
@mitukou1109 mitukou1109 deleted the test/lane_departure_checker_5 branch December 4, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants