Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): remove unused header and divide ThreadSafeData to another file #8990

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 30, 2024

Description

depends #8983

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the fetch-pull-over-path-once branch from 88223ef to dcd75b7 Compare October 1, 2024 02:08
soblin added 9 commits October 1, 2024 11:22
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the fetch-pull-over-path-once branch from dcd75b7 to c91e3b8 Compare October 1, 2024 02:36
@soblin soblin marked this pull request as ready for review October 1, 2024 02:37
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 26.13%. Comparing base (5a0e100) to head (c91e3b8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../behavior_path_goal_planner_module/thread_data.hpp 0.00% 52 Missing ⚠️
..._behavior_path_goal_planner_module/src/manager.cpp 0.00% 4 Missing ⚠️
...havior_path_goal_planner_module/decision_state.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8990      +/-   ##
==========================================
- Coverage   26.16%   26.13%   -0.03%     
==========================================
  Files        1295     1302       +7     
  Lines       96950    97042      +92     
  Branches    39159    39190      +31     
==========================================
  Hits        25364    25364              
- Misses      68992    69068      +76     
- Partials     2594     2610      +16     
Flag Coverage Δ *Carryforward flag
differential 1.22% <0.00%> (?)
total 26.21% <ø> (+0.04%) ⬆️ Carriedforward from 5a0e100

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 35c4f59 into autowarefoundation:main Oct 1, 2024
41 of 42 checks passed
@soblin soblin deleted the fetch-pull-over-path-once branch October 1, 2024 03:45
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…a to another file (autowarefoundation#8990)

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: prakash-kannaiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants