-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_planning_rviz_plugin): set path colors from rviz and add fade_out feature #8972
feat(tier4_planning_rviz_plugin): set path colors from rviz and add fade_out feature #8972
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Could you add the following parameter: We can discuss the implementation once it is set from rviz |
common/tier4_planning_rviz_plugin/include/tier4_planning_rviz_plugin/path/display_base.hpp
Outdated
Show resolved
Hide resolved
common/tier4_planning_rviz_plugin/include/tier4_planning_rviz_plugin/path/display_base.hpp
Outdated
Show resolved
Hide resolved
common/tier4_planning_rviz_plugin/include/tier4_planning_rviz_plugin/path/display_base.hpp
Outdated
Show resolved
Hide resolved
common/tier4_planning_rviz_plugin/include/tier4_planning_rviz_plugin/path/display_base.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
…deoutdistance prop and fix typo Signed-off-by: KhalilSelyan <[email protected]>
6ffe16c
to
88df89d
Compare
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
I think this is ready for review. @KhalilSelyan could you test the last version? |
Signed-off-by: M. Fatih Cırıt <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8972 +/- ##
==========================================
- Coverage 26.16% 26.15% -0.02%
==========================================
Files 1302 1303 +1
Lines 96917 96956 +39
Branches 39150 39155 +5
==========================================
Hits 25354 25354
- Misses 68900 68939 +39
Partials 2663 2663
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also made changes. So it'd be good if you also reviewed @yukkysaito @takayuki5168
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ade_out feature (autowarefoundation#8972) Signed-off-by: KhalilSelyan <[email protected]> Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: prakash-kannaiah <[email protected]>
Description
Updating the style of the path/trajectory display plugin
Related links
Videos
How was this PR tested?
Just run the planning sim demo.
Notes for reviewers
We don't need to modify autoware_launch rviz config file because the defaults are set in the plugin.
Interface changes
New parameters are added:
#3F2EE3
"), "", &property_path_view_)#208AAE
"), "", &property_path_view_)#00E678
"), "", &property_path_view_)Effects on system behavior
None.