Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): set path colors from rviz and add fade_out feature #8972

Merged
merged 10 commits into from
Oct 7, 2024

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Sep 26, 2024

Description

Updating the style of the path/trajectory display plugin

Related links

Videos

How was this PR tested?

Just run the planning sim demo.

Notes for reviewers

We don't need to modify autoware_launch rviz config file because the defaults are set in the plugin.

Interface changes

New parameters are added:

  • property_min_color_("Min Velocity Color", QColor("#3F2EE3"), "", &property_path_view_)
  • property_mid_color_("Mid Velocity Color", QColor("#208AAE"), "", &property_path_view_)
  • property_max_color_("Max Velocity Color", QColor("#00E678"), "", &property_path_view_)
  • property_fade_out_distance_{"Fade Out Distance", 0.0, "[m]", &property_path_view_}

Effects on system behavior

None.

@KhalilSelyan KhalilSelyan added the type:ui-ux User interface, user experience, graphical user interfaces. label Sep 26, 2024
@KhalilSelyan KhalilSelyan requested a review from xmfcx September 26, 2024 13:42
@KhalilSelyan KhalilSelyan self-assigned this Sep 26, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx marked this pull request as draft September 26, 2024 13:48
@xmfcx
Copy link
Contributor

xmfcx commented Sep 26, 2024

Could you add the following parameter:
Parameter name: fade_out_distance
Description: The length from the path’s end where it gradually becomes transparent.

We can discuss the implementation once it is set from rviz

@xmfcx xmfcx changed the title style: improve visualizePath style style(tier4_planning_rviz_plugin): set path colors from rviz and add fade_out feature Sep 26, 2024
@xmfcx xmfcx changed the title style(tier4_planning_rviz_plugin): set path colors from rviz and add fade_out feature feat(tier4_planning_rviz_plugin): set path colors from rviz and add fade_out feature Sep 26, 2024
@xmfcx xmfcx force-pushed the style/update-path-display branch from 6ffe16c to 88df89d Compare October 3, 2024 11:31
M. Fatih Cırıt and others added 4 commits October 3, 2024 15:11
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 4, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Oct 4, 2024

I think this is ready for review.

@KhalilSelyan could you test the last version?

image

image

image

image

Signed-off-by: M. Fatih Cırıt <[email protected]>
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 26.15%. Comparing base (01d9d67) to head (b5a3fad).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...e/tier4_planning_rviz_plugin/path/display_base.hpp 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8972      +/-   ##
==========================================
- Coverage   26.16%   26.15%   -0.02%     
==========================================
  Files        1302     1303       +1     
  Lines       96917    96956      +39     
  Branches    39150    39155       +5     
==========================================
  Hits        25354    25354              
- Misses      68900    68939      +39     
  Partials     2663     2663              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 26.16% <ø> (+<0.01%) ⬆️ Carriedforward from aacafb0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor

xmfcx commented Oct 4, 2024

@xmfcx xmfcx marked this pull request as ready for review October 4, 2024 12:38
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also made changes. So it'd be good if you also reviewed @yukkysaito @takayuki5168

M. Fatih Cırıt added 2 commits October 4, 2024 16:24
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit 88fa2eb into autowarefoundation:main Oct 7, 2024
31 of 32 checks passed
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…ade_out feature (autowarefoundation#8972)

Signed-off-by: KhalilSelyan <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: prakash-kannaiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ui-ux User interface, user experience, graphical user interfaces.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants