Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): modify lane change target boundary check to consider velocity #8961

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Sep 26, 2024

Description

Previously a check was added to ensure the edge of vehicle doesn't exceed target lane boundary during lane change in this PR

But in this recent PR the check was mistakenly removed.

The purpose of this PR is to add the check again and modify the logic to only apply the boundary check if the lane change velocity is greater than the parameterized minimum lane changing velocity.

Related links

None.

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

During lane change, if the candidate path causes ego footprint to exceed target lane far boundary, and lc velocity is above minimum, the path will be unsafe and will not be approved.

…c velocity is above minimum

Signed-off-by: mohammad alqudah <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2024
…check-for-terminal-lc

Signed-off-by: mohammad alqudah <[email protected]>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 28.41%. Comparing base (070e4ee) to head (18addf1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...path_avoidance_by_lane_change_module/src/scene.cpp 0.00% 17 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 7 Missing ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8961      +/-   ##
==========================================
+ Coverage   26.04%   28.41%   +2.37%     
==========================================
  Files        1314     1315       +1     
  Lines       98411    98350      -61     
  Branches    40078    39974     -104     
==========================================
+ Hits        25631    27947    +2316     
- Misses      70092    70346     +254     
+ Partials     2688       57    -2631     
Flag Coverage Δ *Carryforward flag
differential 15.27% <3.84%> (?)
total 28.47% <ø> (+2.43%) ⬆️ Carriedforward from 00866c1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor

kosuke55 commented Sep 27, 2024

@mkquda
could you please solve cppcheck-differential? maybe it can be solved by just rebase on main

@mkquda mkquda merged commit 68abc99 into autowarefoundation:main Sep 27, 2024
30 of 32 checks passed
@mkquda mkquda deleted the RT1-7968-disable-target-lane-boundary-check-for-terminal-lc branch September 27, 2024 05:59
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…er velocity (autowarefoundation#8961)

* check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum

Signed-off-by: mohammad alqudah <[email protected]>

* move functions to relevant module

Signed-off-by: mohammad alqudah <[email protected]>

* suppress unused function cppcheck

Signed-off-by: mohammad alqudah <[email protected]>

* minor change

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: prakash-kannaiah <[email protected]>
zulfaqar-azmi-t4 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…er velocity (autowarefoundation#8961)

* check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum

Signed-off-by: mohammad alqudah <[email protected]>

* move functions to relevant module

Signed-off-by: mohammad alqudah <[email protected]>

* suppress unused function cppcheck

Signed-off-by: mohammad alqudah <[email protected]>

* minor change

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…er velocity (autowarefoundation#8961)

* check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum

Signed-off-by: mohammad alqudah <[email protected]>

* move functions to relevant module

Signed-off-by: mohammad alqudah <[email protected]>

* suppress unused function cppcheck

Signed-off-by: mohammad alqudah <[email protected]>

* minor change

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 21, 2024
…er velocity (autowarefoundation#8961)

* check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum

Signed-off-by: mohammad alqudah <[email protected]>

* move functions to relevant module

Signed-off-by: mohammad alqudah <[email protected]>

* suppress unused function cppcheck

Signed-off-by: mohammad alqudah <[email protected]>

* minor change

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants