-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): modify lane change target boundary check to consider velocity #8961
feat(lane_change): modify lane change target boundary check to consider velocity #8961
Conversation
…c velocity is above minimum Signed-off-by: mohammad alqudah <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…check-for-terminal-lc Signed-off-by: mohammad alqudah <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8961 +/- ##
==========================================
+ Coverage 26.04% 28.41% +2.37%
==========================================
Files 1314 1315 +1
Lines 98411 98350 -61
Branches 40078 39974 -104
==========================================
+ Hits 25631 27947 +2316
- Misses 70092 70346 +254
+ Partials 2688 57 -2631
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mkquda |
…check-for-terminal-lc
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…er velocity (autowarefoundation#8961) * check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum Signed-off-by: mohammad alqudah <[email protected]> * move functions to relevant module Signed-off-by: mohammad alqudah <[email protected]> * suppress unused function cppcheck Signed-off-by: mohammad alqudah <[email protected]> * minor change Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Signed-off-by: prakash-kannaiah <[email protected]>
…er velocity (autowarefoundation#8961) * check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum Signed-off-by: mohammad alqudah <[email protected]> * move functions to relevant module Signed-off-by: mohammad alqudah <[email protected]> * suppress unused function cppcheck Signed-off-by: mohammad alqudah <[email protected]> * minor change Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
…er velocity (autowarefoundation#8961) * check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum Signed-off-by: mohammad alqudah <[email protected]> * move functions to relevant module Signed-off-by: mohammad alqudah <[email protected]> * suppress unused function cppcheck Signed-off-by: mohammad alqudah <[email protected]> * minor change Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
…er velocity (autowarefoundation#8961) * check if candidate path footprint exceeds target lane boundary when lc velocity is above minimum Signed-off-by: mohammad alqudah <[email protected]> * move functions to relevant module Signed-off-by: mohammad alqudah <[email protected]> * suppress unused function cppcheck Signed-off-by: mohammad alqudah <[email protected]> * minor change Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
Description
Previously a check was added to ensure the edge of vehicle doesn't exceed target lane boundary during lane change in this PR
But in this recent PR the check was mistakenly removed.
The purpose of this PR is to add the check again and modify the logic to only apply the boundary check if the lane change velocity is greater than the parameterized minimum lane changing velocity.
Related links
None.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
During lane change, if the candidate path causes ego footprint to exceed target lane far boundary, and lc velocity is above minimum, the path will be unsafe and will not be approved.