Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(osqp_interface): added autoware prefix to osqp_interface #8958

Merged
merged 1 commit into from
Oct 15, 2024
Merged

refactor(osqp_interface): added autoware prefix to osqp_interface #8958

merged 1 commit into from
Oct 15, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Sep 25, 2024

Description

Added autoware prefix to osqp_interface

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

This was referenced Sep 25, 2024
Open
Open
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 25, 2024
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Sep 25, 2024
@esteve esteve force-pushed the prefix-osqp_interface branch 3 times, most recently from 47748cf to 7949a34 Compare September 25, 2024 14:09
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.82%. Comparing base (9d78e00) to head (3192ad6).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ning/autoware_path_optimizer/src/mpt_optimizer.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8958      +/-   ##
==========================================
+ Coverage   26.77%   26.82%   +0.05%     
==========================================
  Files        1296     1303       +7     
  Lines       95822    96092     +270     
  Branches    39145    39260     +115     
==========================================
+ Hits        25657    25779     +122     
- Misses      67518    67676     +158     
+ Partials     2647     2637      -10
Flag Coverage Δ *Carryforward flag
differential 27.27% <85.71%> (?)
total 26.73% <ø> (-0.04%) ⬇️ Carriedforward from 9d78e00

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve marked this pull request as ready for review September 25, 2024 15:32
@esteve esteve enabled auto-merge (squash) October 9, 2024 08:20
@esteve
Copy link
Contributor Author

esteve commented Oct 9, 2024

@xmfcx @mitsudome-r can you have a look at this when you have a moment? Thanks.

@esteve esteve force-pushed the prefix-osqp_interface branch from 7949a34 to 3192ad6 Compare October 9, 2024 09:41
@esteve
Copy link
Contributor Author

esteve commented Oct 14, 2024

@TakaHoribe @go-sakayori @kosuke55 @mkuri @rej55 @satoshi-ota @takayuki5168 @yuki-takagi-66 @mitsudome-r @xmfcx can you please have a look at these changes? Thanks.

go-sakayori
go-sakayori approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for autoware_velocity_smoother

@esteve esteve merged commit d137f7c into autowarefoundation:main Oct 15, 2024
29 of 32 checks passed
@esteve esteve deleted the prefix-osqp_interface branch October 15, 2024 01:27
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 16, 2024
@esteve @prakash-kannaiah
refactor(osqp_interface): added autoware prefix to osqp_interface (au…
c4ff1ce 
…towarefoundation#8958)

Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: prakash-kannaiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-clem maxime-clem maxime-clem approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@go-sakayori go-sakayori go-sakayori approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esteve @go-sakayori @takayuki5168 @maxime-clem