-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_lidar_marker_localization): fix segmentation fault #8943
fix(autoware_lidar_marker_localization): fix segmentation fault #8943
Conversation
Signed-off-by: Yamato Ando <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
I will test it later and open this PR |
This pull request has been automatically marked as stale because it has not had recent activity. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8943 +/- ##
==========================================
- Coverage 29.47% 29.47% -0.01%
==========================================
Files 1424 1424
Lines 107880 107889 +9
Branches 42827 42829 +2
==========================================
Hits 31801 31801
- Misses 73010 73019 +9
Partials 3069 3069
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
51c7ffc
into
autowarefoundation:main
Description
To prevent out-of-bounds access errors in the subsequent program when
bin_num
is smaller thanparam_.intensity_pattern.size()
, a countermeasure has been implemented.Related links
Parent Issue:
How was this PR tested?
Test with sample dataset for lidar_marker_localization.
Reproduce a situation where bin_num becomes smaller by methods such as narrowing the range of LiDAR point clouds.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.