Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_lidar_marker_localization): fix segmentation fault #8943

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Sep 24, 2024

Description

To prevent out-of-bounds access errors in the subsequent program when bin_num is smaller than param_.intensity_pattern.size(), a countermeasure has been implemented.

Related links

Parent Issue:

  • Link

How was this PR tested?

Test with sample dataset for lidar_marker_localization.

Reproduce a situation where bin_num becomes smaller by methods such as narrowing the range of LiDAR point clouds.

    min_x: -0.1
    max_x: 0.1

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Yamato Ando <[email protected]>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YamatoAndo
Copy link
Contributor Author

I will test it later and open this PR

Copy link

stale bot commented Nov 23, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 23, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jan 20, 2025
@YamatoAndo YamatoAndo marked this pull request as ready for review January 20, 2025 08:38
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 20, 2025
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) January 20, 2025 08:46
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.47%. Comparing base (ae436b3) to head (596ac3c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ar_marker_localizer/src/lidar_marker_localizer.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8943      +/-   ##
==========================================
- Coverage   29.47%   29.47%   -0.01%     
==========================================
  Files        1424     1424              
  Lines      107880   107889       +9     
  Branches    42827    42829       +2     
==========================================
  Hits        31801    31801              
- Misses      73010    73019       +9     
  Partials     3069     3069              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.47% <ø> (ø) Carriedforward from ae436b3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 51c7ffc into autowarefoundation:main Jan 20, 2025
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants